mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57743: Updated the agent to generate executor secrets.
Date Sat, 25 Mar 2017 04:32:42 GMT


> On March 25, 2017, 12:22 a.m., Anand Mazumdar wrote:
> > src/slave/slave.cpp
> > Lines 2558 (patched)
> > <https://reviews.apache.org/r/57743/diff/10/?file=1674559#file1674559line2558>
> >
> >     Any reasons why you did not use the `!=` operator directly? Also, can you log
the type of secret that was produced by the generator?

I added another patch, previous to this one, with a streaming operator overload to facilitate
this logging.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57743/#review170063
-----------------------------------------------------------


On March 25, 2017, 4:32 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57743/
> -----------------------------------------------------------
> 
> (Updated March 25, 2017, 4:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the agent code to generate executor
> authentication tokens when executor authentication is
> enabled. For now, the generated `Secret` objects must
> be of `VALUE` type, and they're passed directly into the
> executor environment.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp e06525bf6a6596d35ae038e576f12eb96ab65a35 
>   src/slave/slave.cpp d68d6b9a1bae79bed27babe020bf8a5d41d116bd 
> 
> 
> Diff: https://reviews.apache.org/r/57743/diff/11/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message