mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57924: Added 'shutdownExecutor' methods to the mock agent.
Date Sat, 25 Mar 2017 04:36:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57924/
-----------------------------------------------------------

(Updated March 25, 2017, 4:36 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
-------

Made the agent's `shutdownExecutor` method `virtual`.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description
-------

This patch adds both mocked and unmocked `shutdownExecutor` methods
to the mock agent to facilitate testing of failure scenarios related
to executor secret generation.


Diffs (updated)
-----

  src/slave/slave.hpp e06525bf6a6596d35ae038e576f12eb96ab65a35 
  src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751 
  src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf 


Diff: https://reviews.apache.org/r/57924/diff/2/

Changes: https://reviews.apache.org/r/57924/diff/1-2/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message