mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 57743: Updated the agent to generate executor secrets.
Date Sat, 25 Mar 2017 17:21:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57743/#review170084
-----------------------------------------------------------




src/slave/slave.cpp
Lines 2549 (patched)
<https://reviews.apache.org/r/57743/#comment242872>

    Remove Extra newline?



src/slave/slave.cpp
Lines 2552 (patched)
<https://reviews.apache.org/r/57743/#comment242873>

    How about being consistent with other validation failure strings in our code:
    
    "Failed to validate generated secret: ..."



src/slave/slave.cpp
Lines 2555-2557 (patched)
<https://reviews.apache.org/r/57743/#comment242874>

    How about the following string:
    
    "Expecting generated secret to be of VALUE type instead of " + stringify(secret.type())
+ " type; only VALUE type secrets are supported at this time"



src/slave/slave.cpp
Lines 2607 (patched)
<https://reviews.apache.org/r/57743/#comment242875>

    Can you add a comment for posterity on why this is needed?



src/slave/slave.cpp
Lines 2618 (patched)
<https://reviews.apache.org/r/57743/#comment242876>

    s/CHECK/CHECK_EQ



src/slave/slave.cpp
Lines 6681-6683 (original), 6899-6901 (patched)
<https://reviews.apache.org/r/57743/#comment242877>

    Why this change here? If needed can we do it in a separate review.


- Anand Mazumdar


On March 25, 2017, 4:32 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57743/
> -----------------------------------------------------------
> 
> (Updated March 25, 2017, 4:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the agent code to generate executor
> authentication tokens when executor authentication is
> enabled. For now, the generated `Secret` objects must
> be of `VALUE` type, and they're passed directly into the
> executor environment.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp e06525bf6a6596d35ae038e576f12eb96ab65a35 
>   src/slave/slave.cpp d68d6b9a1bae79bed27babe020bf8a5d41d116bd 
> 
> 
> Diff: https://reviews.apache.org/r/57743/diff/11/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message