mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57883: Added new tests for executor secret generation.
Date Sat, 25 Mar 2017 17:45:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57883/
-----------------------------------------------------------

(Updated March 25, 2017, 5:45 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description
-------

This patch adds new tests,
`SlaveTest.RunTaskGroupFailedSecretGeneration` and
`SlaveTest.RunTaskGroupInvalidExecutorSecret`, to
verify the agent's behavior when generation of the
executor secret fails.


Diffs (updated)
-----

  src/tests/slave_tests.cpp c31c670b667240c4876d415aa5cf90cb34273e8a 


Diff: https://reviews.apache.org/r/57883/diff/6/

Changes: https://reviews.apache.org/r/57883/diff/5-6/


Testing
-------

`make check`
`bin/mesos-tests.sh --gtest_filter="*SlaveTest.RunTaskGroupFailedSecretGeneration*:SlaveTest.RunTaskGroupInvalidExecutorSecret*"
--gtest_repeat=-1 --gtest_break_on_failure` was used to verify that the new tests are not
flaky.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message