mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57929: Added a streaming operator overload for Secret::Type.
Date Sat, 25 Mar 2017 19:02:43 GMT


> On March 25, 2017, 6:51 p.m., Anand Mazumdar wrote:
> > include/mesos/type_utils.hpp
> > Lines 325 (patched)
> > <https://reviews.apache.org/r/57929/diff/1/?file=1674801#file1674801line325>
> >
> >     Move this after L348 to be consistent with the ordering of other functions?

Looks like the declaration of `std::ostream& operator<<(std::ostream& stream,
const RLimitInfo& rlimitInfo);` is out-of-order; will fix that in a follow-up patch.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57929/#review170098
-----------------------------------------------------------


On March 25, 2017, 4:30 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57929/
> -----------------------------------------------------------
> 
> (Updated March 25, 2017, 4:30 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an `operator<<` overload for the `Secret::Type`
> protobuf enum to facilitate logging.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 19f34a7d8bfa373ca6c51a2061942f709dffb846 
>   include/mesos/v1/mesos.hpp 0fecc4a971cc28de28c5cec5226cce6231c7682f 
>   src/common/type_utils.cpp 3ab2dc1a27d7e0f97e0f37df2608ccec06f5936b 
>   src/v1/mesos.cpp b21e1e77a816386b03bd378a36992d70c4971fcc 
> 
> 
> Diff: https://reviews.apache.org/r/57929/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message