From reviews-return-56741-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 1 18:46:04 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0F52B190C9 for ; Wed, 1 Mar 2017 18:46:04 +0000 (UTC) Received: (qmail 8831 invoked by uid 500); 1 Mar 2017 18:46:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 8800 invoked by uid 500); 1 Mar 2017 18:46:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 8789 invoked by uid 99); 1 Mar 2017 18:46:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 18:46:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 356DCC05AA; Wed, 1 Mar 2017 18:46:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.453 X-Spam-Level: * X-Spam-Status: No, score=1.453 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id GcZNrMlwwckW; Wed, 1 Mar 2017 18:46:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 01A185F1A1; Wed, 1 Mar 2017 18:46:01 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 92D62E031F; Wed, 1 Mar 2017 18:46:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8E9B8C40426; Wed, 1 Mar 2017 18:46:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6137634369250838451==" MIME-Version: 1.0 Subject: Re: Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix. From: Joris Van Remoortere To: Alex Clemmer , Alex Naparu , Artem Harutyunyan , Joseph Wu , Michael Park Cc: Daniel Pravat , Joris Van Remoortere , mesos Date: Wed, 01 Mar 2017 18:46:00 -0000 Message-ID: <20170301184600.39251.27121@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joris Van Remoortere X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53707/ X-Sender: Joris Van Remoortere References: <20161114054539.20485.50433@reviews.apache.org> In-Reply-To: <20161114054539.20485.50433@reviews.apache.org> Reply-To: Joris Van Remoortere X-ReviewRequest-Repository: mesos --===============6137634369250838451== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53707/#review167530 ----------------------------------------------------------- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Nov. 14, 2016, 5:45 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53707/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 5:45 a.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Added a Windows isolator. Removed `#ifdef`-ed block from Posix. > > > Diffs > ----- > > src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 270d2aa6e06f323bfb6eee3b703a24a600a55871 > src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 2bf011d3e7b014a17f759851d755b161c897b131 > src/slave/containerizer/mesos/isolators/filesystem/windows.cpp f169c380f803a2111b1612cee60250ee9a30ef2e > > > Diff: https://reviews.apache.org/r/53707/diff/1/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > > --===============6137634369250838451==--