From reviews-return-56751-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 1 18:55:47 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F06A01916F for ; Wed, 1 Mar 2017 18:55:47 +0000 (UTC) Received: (qmail 35931 invoked by uid 500); 1 Mar 2017 18:55:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 35900 invoked by uid 500); 1 Mar 2017 18:55:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 35846 invoked by uid 99); 1 Mar 2017 18:55:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 18:55:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0B6C9C05AA; Wed, 1 Mar 2017 18:55:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.001 X-Spam-Level: X-Spam-Status: No, score=0.001 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id G_qcxv5Mzhem; Wed, 1 Mar 2017 18:55:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E0F575F254; Wed, 1 Mar 2017 18:55:45 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 71CBCE0238; Wed, 1 Mar 2017 18:55:45 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5377BC40426; Wed, 1 Mar 2017 18:55:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7455207949459096721==" MIME-Version: 1.0 Subject: Re: Review Request 57132: Fixed WebUI data-key. From: Benjamin Mahler To: Benjamin Mahler Cc: Jay Guo , mesos Date: Wed, 01 Mar 2017 18:55:45 -0000 Message-ID: <20170301185545.39251.55437@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57132/ X-Sender: Benjamin Mahler X-ReviewBoard-ShipIt: 1 References: <20170301102343.40981.43846@reviews-vm2.apache.org> In-Reply-To: <20170301102343.40981.43846@reviews-vm2.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============7455207949459096721== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57132/#review167541 ----------------------------------------------------------- Ship it! There are probably other `data-key`s that are broken too, I didn't do a sweep when I had suggested fixing these :) - Benjamin Mahler On March 1, 2017, 10:23 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57132/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 10:23 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6657 > https://issues.apache.org/jira/browse/MESOS-6657 > > > Repository: mesos > > > Description > ------- > > Some of the data-key are incorrect, which causes sorting problem. > > > Diffs > ----- > > src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297 > > > Diff: https://reviews.apache.org/r/57132/diff/2/ > > > Testing > ------- > > > Thanks, > > Jay Guo > > --===============7455207949459096721==--