From reviews-return-57171-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 9 13:46:28 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A60719694 for ; Thu, 9 Mar 2017 13:46:28 +0000 (UTC) Received: (qmail 39374 invoked by uid 500); 9 Mar 2017 13:46:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 39351 invoked by uid 500); 9 Mar 2017 13:46:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 38773 invoked by uid 99); 9 Mar 2017 13:46:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 13:46:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E4FD71A7A64; Thu, 9 Mar 2017 13:46:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id xzZgmjX_6o3c; Thu, 9 Mar 2017 13:46:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D07755F39F; Thu, 9 Mar 2017 13:46:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 12238E0156; Thu, 9 Mar 2017 13:46:18 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DA74FC400C2; Thu, 9 Mar 2017 13:46:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6914587336341542703==" MIME-Version: 1.0 Subject: Re: Review Request 57384: Added `Containerizer::cleanupArtifacts`. From: =?utf-8?q?Gast=C3=B3n_Kleiman?= To: Jie Yu , Kevin Klues , Vinod Kone , Alexander Rukletsov Cc: =?utf-8?q?Gast=C3=B3n_Kleiman?= , mesos Date: Thu, 09 Mar 2017 13:46:17 -0000 Message-ID: <20170309134617.13769.1117@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cnoreply=40reviews=2Eapache=2Eorg?=@reviews.apache.org, =?utf-8?q?=3E?=@reviews.apache.org X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57384/ X-Sender: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cnoreply=40reviews=2Eapache=2Eorg?= =?utf-8?q?=3E?= References: <20170308105048.19286.84469@reviews-vm2.apache.org> In-Reply-To: <20170308105048.19286.84469@reviews-vm2.apache.org> Reply-To: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cgaston=40mesosphere=2Eio=3E?=@reviews.apache.org X-ReviewRequest-Repository: mesos --===============6914587336341542703== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/ ----------------------------------------------------------- (Updated March 9, 2017, 1:46 p.m.) Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod Kone. Changes ------- Addressed Vinod's feedback (modulo naming). Bugs: MESOS-7120 https://issues.apache.org/jira/browse/MESOS-7120 Repository: mesos Description ------- This new method cleans up the sandbox and runtime directories of a terminated nested container. Diffs (updated) ----- src/slave/containerizer/containerizer.hpp f65a9b9761fc254bd0778bf13aac9b256497b22f src/slave/containerizer/mesos/containerizer.hpp 09f94ccb3224c14a9324961b789455b119ec2257 src/slave/containerizer/mesos/containerizer.cpp b001d0265ec73822193eaac74c631930acce90c0 src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c Diff: https://reviews.apache.org/r/57384/diff/3/ Changes: https://reviews.apache.org/r/57384/diff/2-3/ Testing ------- Added a test and verified that it works on Linux. Thanks, Gastón Kleiman --===============6914587336341542703==--