From reviews-return-57174-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 9 14:18:44 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8EE4919856 for ; Thu, 9 Mar 2017 14:18:44 +0000 (UTC) Received: (qmail 59372 invoked by uid 500); 9 Mar 2017 14:18:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 59344 invoked by uid 500); 9 Mar 2017 14:18:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 58790 invoked by uid 99); 9 Mar 2017 14:18:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 14:18:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1A0C81803A6; Thu, 9 Mar 2017 14:18:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.2 X-Spam-Level: *** X-Spam-Status: No, score=3.2 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 42nYuVWw0U30; Thu, 9 Mar 2017 14:18:38 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 84EEF5F1EE; Thu, 9 Mar 2017 14:18:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D4D4FE00D9; Thu, 9 Mar 2017 14:18:30 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A8A06C400C2; Thu, 9 Mar 2017 14:18:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7663150209355883607==" MIME-Version: 1.0 Subject: Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer. From: Alexander Rojas To: Adam B , Jie Yu , Alexander Rojas , Kevin Klues , Vinod Kone , Alexander Rukletsov Cc: =?utf-8?q?Gast=C3=B3n_Kleiman?= , mesos Date: Thu, 09 Mar 2017 14:18:30 -0000 Message-ID: <20170309141830.27210.42473@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rojas X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57386/ X-Sender: Alexander Rojas References: <20170309135431.13769.28542@reviews-vm2.apache.org> In-Reply-To: <20170309135431.13769.28542@reviews-vm2.apache.org> Reply-To: Alexander Rojas X-ReviewRequest-Repository: mesos --===============7663150209355883607== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57386/#review168447 ----------------------------------------------------------- In summary and description, change /auth/authz/. Using just auth doesn't clarify if you mean authorization or authentication (the best is to use the whole word). Also, I don't think it is a good practice to use the same text in the summary as in the description, there was even a public discussion discouraging us about it. - Alexander Rojas On March 9, 2017, 2:54 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57386/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 2:54 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie Yu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-7120 > https://issues.apache.org/jira/browse/MESOS-7120 > > > Repository: mesos > > > Description > ------- > > Introduced changes to the auth protos needed for DeleteNestedContainer. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 > include/mesos/authorizer/authorizer.proto fdc4817ce74c45d792fc47f064f7909a83b1657d > > > Diff: https://reviews.apache.org/r/57386/diff/3/ > > > Testing > ------- > > > Thanks, > > Gastón Kleiman > > --===============7663150209355883607==--