From reviews-return-57217-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 9 22:05:05 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 77274194AF for ; Thu, 9 Mar 2017 22:05:05 +0000 (UTC) Received: (qmail 53271 invoked by uid 500); 9 Mar 2017 22:05:05 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 53239 invoked by uid 500); 9 Mar 2017 22:05:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 53228 invoked by uid 99); 9 Mar 2017 22:05:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 22:05:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 99D0C186130; Thu, 9 Mar 2017 22:05:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id zq17CkVBV7aB; Thu, 9 Mar 2017 22:05:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9F5805F39F; Thu, 9 Mar 2017 22:05:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 66EBFE0045; Thu, 9 Mar 2017 22:05:01 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3B176C408BC; Thu, 9 Mar 2017 22:05:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3992402632591346736==" MIME-Version: 1.0 Subject: Re: Review Request 57166: Updated role validation for hierarchical roles. From: Michael Park To: Benjamin Bannier , Michael Park Cc: Neil Conway , Qian Zhang , mesos Date: Thu, 09 Mar 2017 22:05:00 -0000 Message-ID: <20170309220500.10814.81842@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Michael Park X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57166/ X-Sender: Michael Park References: <20170307052638.40992.63218@reviews-vm2.apache.org> In-Reply-To: <20170307052638.40992.63218@reviews-vm2.apache.org> Reply-To: Michael Park X-ReviewRequest-Repository: mesos --===============3992402632591346736== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 6, 2017, 9:26 p.m., Michael Park wrote: > > src/common/roles.cpp > > Lines 72 (patched) > > > > > > For these error messages, how about we say something like this? > > > > ```cpp > > "A role cannot start with a slash, given: '" + role + "'" > > ``` > > > > Here and below. > > Neil Conway wrote: > The "given" phrasing here seems confusing to me (it isn't clear who is being "given" what...). Personally I think the current phrasing is okay... Okay, I think I was just trying to suggest that the statement should make a general statement about all roles, rather than say the __particular role__ cannot . - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57166/#review168096 ----------------------------------------------------------- On March 7, 2017, 7:38 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57166/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 7:38 a.m.) > > > Review request for mesos, Benjamin Bannier and Michael Park. > > > Repository: mesos > > > Description > ------- > > Role names can now contain forward slashes. Each component in a role > name must now be validated separately. > > > Diffs > ----- > > src/common/roles.cpp 31774a9b8f99f5efeed35b1c3e3486e05ca00f6a > src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 > > > Diff: https://reviews.apache.org/r/57166/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > > --===============3992402632591346736==--