From reviews-return-57219-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 9 22:23:42 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9EB0A195CF for ; Thu, 9 Mar 2017 22:23:42 +0000 (UTC) Received: (qmail 5733 invoked by uid 500); 9 Mar 2017 22:23:42 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 5690 invoked by uid 500); 9 Mar 2017 22:23:42 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 5353 invoked by uid 99); 9 Mar 2017 22:23:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 22:23:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B6EB8C1F25; Thu, 9 Mar 2017 22:23:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id paFj9Ttcv1wl; Thu, 9 Mar 2017 22:23:40 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 35F3061E29; Thu, 9 Mar 2017 22:23:40 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B4848E0045; Thu, 9 Mar 2017 22:23:31 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8D2ADC408BC; Thu, 9 Mar 2017 22:23:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5746078188046203864==" MIME-Version: 1.0 Subject: Review Request 57480: Replaced an instance of `/dev/null` with `os::DEV_NULL`. From: Joseph Wu To: Alex Clemmer Cc: Joseph Wu , mesos Date: Thu, 09 Mar 2017 22:23:31 -0000 Message-ID: <20170309222331.10814.2833@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57480/ X-Sender: Joseph Wu Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============5746078188046203864== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57480/ ----------------------------------------------------------- Review request for mesos, Andrew Schwartzmeyer and Alex Clemmer. Repository: mesos Description ------- `os::DEV_NULL` is a constant defined in stout that points to `/dev/null` on Posix and `NUL` on Windows. The two locations behave similarly on their respective platforms. This change future-proofs this code on Windows (only fails at runtime) in case the related features are added to the Windows build. Diffs ----- 3rdparty/libprocess/src/io.cpp be41e7fc7727512d5201b8e059f5b61c31ff88ef Diff: https://reviews.apache.org/r/57480/diff/1/ Testing ------- See next review. Thanks, Joseph Wu --===============5746078188046203864==--