From reviews-return-57224-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 9 22:44:46 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95F371973B for ; Thu, 9 Mar 2017 22:44:46 +0000 (UTC) Received: (qmail 66113 invoked by uid 500); 9 Mar 2017 22:44:46 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 66092 invoked by uid 500); 9 Mar 2017 22:44:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 65130 invoked by uid 99); 9 Mar 2017 22:44:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 22:44:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DE7B71A7AC8; Thu, 9 Mar 2017 22:34:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id WCL_H9w9CdDQ; Thu, 9 Mar 2017 22:34:51 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A94FC5F1EE; Thu, 9 Mar 2017 22:34:50 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E8E09E0045; Thu, 9 Mar 2017 22:34:47 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D803EC40426; Thu, 9 Mar 2017 22:34:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1436375936306657684==" MIME-Version: 1.0 Subject: Re: Review Request 56028: Consistently add the FollowSymlink stat argument on Windows. From: Joseph Wu To: Joris Van Remoortere , Alex Clemmer , Joseph Wu , Jiang Yan Xu , Michael Park Cc: James Peach , mesos Date: Thu, 09 Mar 2017 22:34:47 -0000 Message-ID: <20170309223447.10815.12254@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56028/ X-Sender: Joseph Wu References: <20170309004209.27210.40904@reviews-vm2.apache.org> In-Reply-To: <20170309004209.27210.40904@reviews-vm2.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============1436375936306657684== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56028/#review168535 ----------------------------------------------------------- 3rdparty/stout/include/stout/os/windows/stat.hpp Lines 41-43 (patched) Don't use `WindowsError` here, as you'll give the impression this is a Windows API error. Normal `Error` + a normal message will suffice. Ditto on the below. - Joseph Wu On March 8, 2017, 4:42 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56028/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 4:42 p.m.) > > > Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, Michael Park, and Jiang Yan Xu. > > > Bugs: MESOS-7021 > https://issues.apache.org/jira/browse/MESOS-7021 > > > Repository: mesos > > > Description > ------- > > Consistently add the FollowSymlink stat argument on Windows. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/stat.hpp e7f471b828d96bb5cd01823dd78c8570730712ea > > > Diff: https://reviews.apache.org/r/56028/diff/4/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > > --===============1436375936306657684==--