From reviews-return-57225-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 9 23:14:10 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0843198E4 for ; Thu, 9 Mar 2017 23:14:10 +0000 (UTC) Received: (qmail 53682 invoked by uid 500); 9 Mar 2017 23:14:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 53649 invoked by uid 500); 9 Mar 2017 23:14:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 53637 invoked by uid 99); 9 Mar 2017 23:14:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 23:14:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1FFE41A7ACC; Thu, 9 Mar 2017 23:14:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4p0LVoRPCMH6; Thu, 9 Mar 2017 23:14:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C41085F39F; Thu, 9 Mar 2017 23:14:07 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 88FCEE0596; Thu, 9 Mar 2017 23:14:05 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 61EF0C40426; Thu, 9 Mar 2017 23:14:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6956000203308736121==" MIME-Version: 1.0 Subject: Re: Review Request 57190: Updated agent for hierarchical roles. From: Benjamin Bannier To: Neil Conway , Benjamin Mahler , Michael Park Cc: Benjamin Bannier , Mesos Reviewbot , mesos Date: Thu, 09 Mar 2017 23:14:05 -0000 Message-ID: <20170309231405.10815.47074@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57190/ X-Sender: Benjamin Bannier References: <20170302233158.39766.57534@reviews-vm2.apache.org> In-Reply-To: <20170302233158.39766.57534@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============6956000203308736121== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/ ----------------------------------------------------------- (Updated March 10, 2017, 12:14 a.m.) Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway. Changes ------- Disabled test on Windows for now. Bugs: MESOS-7047 https://issues.apache.org/jira/browse/MESOS-7047 Repository: mesos Description ------- This commit adjusts the way persistent volumes are stored on the agent. Instead of interpreting the role of the volume as a literal path, we replace `/` with ` ` when creating the path. This prevents that subdirectories are created for volumes with hierarchical roles. Directly interpreting the role as a path is undesirable as it can lead to volumes overlapping (e.g., a volume with role `a/b/c/d` and id `id` would be visible as `id` in a volume with role `a/b/c` and id `d`). Diffs (updated) ----- src/slave/paths.cpp 38ad1993aa36a627ec97a7865488677495ee4c5a src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 Diff: https://reviews.apache.org/r/57190/diff/4/ Changes: https://reviews.apache.org/r/57190/diff/3-4/ Testing ------- make check Thanks, Benjamin Bannier --===============6956000203308736121==--