----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/ ----------------------------------------------------------- (Updated March 10, 2017, 12:14 a.m.) Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway. Changes ------- Disabled test on Windows for now. Bugs: MESOS-7047 https://issues.apache.org/jira/browse/MESOS-7047 Repository: mesos Description ------- This commit adjusts the way persistent volumes are stored on the agent. Instead of interpreting the role of the volume as a literal path, we replace `/` with ` ` when creating the path. This prevents that subdirectories are created for volumes with hierarchical roles. Directly interpreting the role as a path is undesirable as it can lead to volumes overlapping (e.g., a volume with role `a/b/c/d` and id `id` would be visible as `id` in a volume with role `a/b/c` and id `d`). Diffs (updated) ----- src/slave/paths.cpp 38ad1993aa36a627ec97a7865488677495ee4c5a src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 Diff: https://reviews.apache.org/r/57190/diff/4/ Changes: https://reviews.apache.org/r/57190/diff/3-4/ Testing ------- make check Thanks, Benjamin Bannier