From reviews-return-57239-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 9 23:47:34 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E501C19ACA for ; Thu, 9 Mar 2017 23:47:33 +0000 (UTC) Received: (qmail 80085 invoked by uid 500); 9 Mar 2017 23:47:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 80056 invoked by uid 500); 9 Mar 2017 23:47:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 80044 invoked by uid 99); 9 Mar 2017 23:47:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 23:47:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 270E9C0385; Thu, 9 Mar 2017 23:47:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.001 X-Spam-Level: *** X-Spam-Status: No, score=3.001 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1q3tISaAQU-F; Thu, 9 Mar 2017 23:47:32 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 89B9C5FB59; Thu, 9 Mar 2017 23:47:31 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 36A86E0045; Thu, 9 Mar 2017 23:47:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 266CBC408BC; Thu, 9 Mar 2017 23:47:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3397953016264171088==" MIME-Version: 1.0 Subject: Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'. From: Greg Mann To: Alexander Rojas , Vinod Kone , Till Toenshoff , Jan Schlicht Cc: Greg Mann , mesos Date: Thu, 09 Mar 2017 23:47:22 -0000 Message-ID: <20170309234722.10814.29722@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56475/ X-Sender: Greg Mann References: <20170309234559.767.21501@reviews-vm2.apache.org> In-Reply-To: <20170309234559.767.21501@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============3397953016264171088== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/ ----------------------------------------------------------- (Updated March 9, 2017, 11:47 p.m.) Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone. Bugs: MESOS-7004 https://issues.apache.org/jira/browse/MESOS-7004 Repository: mesos Description (updated) ------- This patch adds a unit test to verify the functionality of the `CombinedAuthenticator`. The new test is called `CombinedAuthenticatorTest.MultipleAuthenticators`. Diffs ----- src/tests/http_authentication_tests.cpp d5fabf0058755502f19eb6385bd99a0d45419508 Diff: https://reviews.apache.org/r/56475/diff/2/ Testing (updated) ------- The following commands were used to test: `make check` `bin/mesos-tests.sh --gtest_filter="*CombinedAuthenticator*" --gtest_repeat=-1 --gtest_break_on_failure` Thanks, Greg Mann --===============3397953016264171088==--