From reviews-return-57263-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Mar 10 08:43:29 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9FCB019E84 for ; Fri, 10 Mar 2017 08:43:29 +0000 (UTC) Received: (qmail 16931 invoked by uid 500); 10 Mar 2017 08:43:29 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 16899 invoked by uid 500); 10 Mar 2017 08:43:29 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 16880 invoked by uid 99); 10 Mar 2017 08:43:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2017 08:43:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AC331C0912; Fri, 10 Mar 2017 08:43:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id dBXRez68fc_w; Fri, 10 Mar 2017 08:43:27 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D2DDA5FAE0; Fri, 10 Mar 2017 08:43:26 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D66B1E0294; Fri, 10 Mar 2017 08:43:25 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id AB8D7C40426; Fri, 10 Mar 2017 08:43:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1029059252889052859==" MIME-Version: 1.0 Subject: Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`. From: Alexander Rojas To: Benjamin Bannier , Adam B Cc: mesos , Alexander Rojas Date: Fri, 10 Mar 2017 08:43:25 -0000 Message-ID: <20170310084325.767.39245@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rojas X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57472/ X-Sender: Alexander Rojas References: <20170310081818.767.87546@reviews-vm2.apache.org> In-Reply-To: <20170310081818.767.87546@reviews-vm2.apache.org> Reply-To: Alexander Rojas X-ReviewRequest-Repository: mesos --===============1029059252889052859== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57472/ ----------------------------------------------------------- (Updated March 10, 2017, 9:43 a.m.) Review request for mesos, Adam B and Benjamin Bannier. Changes ------- Rebased Repository: mesos Description ------- The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation more than six months ago, where they were replaced for the more convenient `UpdateQuota` ACL. The deprecation cycle for these actions is finally due while at the same time removing will make easier to implement the hierarchical role feature in a generic way. Diffs (updated) ----- CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 Diff: https://reviews.apache.org/r/57472/diff/2/ Changes: https://reviews.apache.org/r/57472/diff/1-2/ Testing ------- `make check` Thanks, Alexander Rojas --===============1029059252889052859==--