From reviews-return-57271-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Mar 10 12:44:09 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C401C1981E for ; Fri, 10 Mar 2017 12:44:09 +0000 (UTC) Received: (qmail 1669 invoked by uid 500); 10 Mar 2017 12:44:09 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 1634 invoked by uid 500); 10 Mar 2017 12:44:09 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 1622 invoked by uid 99); 10 Mar 2017 12:44:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2017 12:44:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C9447C2791; Fri, 10 Mar 2017 12:44:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id zu_9dm8IMpnW; Fri, 10 Mar 2017 12:44:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1C64F5FB6A; Fri, 10 Mar 2017 12:44:07 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 651C3E0294; Fri, 10 Mar 2017 12:44:05 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3A4A2C40426; Fri, 10 Mar 2017 12:44:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6056440638544818863==" MIME-Version: 1.0 Subject: Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'. From: Mesos Reviewbot To: Alexander Rojas , Vinod Kone , Till Toenshoff , Jan Schlicht Cc: Mesos Reviewbot , Greg Mann , mesos Date: Fri, 10 Mar 2017 12:44:05 -0000 Message-ID: <20170310124405.10815.94040@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56475/ X-Sender: Mesos Reviewbot References: <20170310003516.10815.30723@reviews-vm2.apache.org> In-Reply-To: <20170310003516.10815.30723@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============6056440638544818863== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/#review168603 ----------------------------------------------------------- Patch looks great! Reviews applied: [56474, 56476, 56475] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 10, 2017, 12:35 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56475/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 12:35 a.m.) > > > Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7004 > https://issues.apache.org/jira/browse/MESOS-7004 > > > Repository: mesos > > > Description > ------- > > This patch adds a unit test to verify the functionality of > the `CombinedAuthenticator`. The new test is called > `CombinedAuthenticatorTest.MultipleAuthenticators`. > > > Diffs > ----- > > src/tests/http_authentication_tests.cpp d5fabf0058755502f19eb6385bd99a0d45419508 > > > Diff: https://reviews.apache.org/r/56475/diff/3/ > > > Testing > ------- > > The following commands were used to test: > `make check` > `bin/mesos-tests.sh --gtest_filter="*CombinedAuthenticator*" --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > > --===============6056440638544818863==--