From reviews-return-57483-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Mar 14 23:05:51 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 03E071929D for ; Tue, 14 Mar 2017 23:05:51 +0000 (UTC) Received: (qmail 23930 invoked by uid 500); 14 Mar 2017 23:05:50 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23895 invoked by uid 500); 14 Mar 2017 23:05:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23884 invoked by uid 99); 14 Mar 2017 23:05:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Mar 2017 23:05:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1DC4418056F; Tue, 14 Mar 2017 23:05:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Ijp8Dd1GwNPq; Tue, 14 Mar 2017 23:05:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F11675F2EF; Tue, 14 Mar 2017 23:05:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3D9FAE0051; Tue, 14 Mar 2017 23:05:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 2B9E3C406ED; Tue, 14 Mar 2017 23:05:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2076152911891286404==" MIME-Version: 1.0 Subject: Re: Review Request 57534: Added and implemented RegisterAgent ACL. From: Anindya Sinha To: Adam B , Anindya Sinha , Greg Mann , Alexander Rojas Cc: Jiang Yan Xu , mesos Date: Tue, 14 Mar 2017 23:05:44 -0000 Message-ID: <20170314230544.4332.71159@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anindya Sinha X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57534/ X-Sender: Anindya Sinha References: <20170314181726.7929.27145@reviews-vm2.apache.org> In-Reply-To: <20170314181726.7929.27145@reviews-vm2.apache.org> Reply-To: Anindya Sinha X-ReviewRequest-Repository: mesos --===============2076152911891286404== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review168940 ----------------------------------------------------------- include/mesos/authorizer/acls.proto Line 440 (original), 450 (patched) Not your change, but maybe move that down so the ids are in ascending order to avoid issues in future? include/mesos/authorizer/acls.proto Lines 459 (patched) `remove_nested_containers` uses 33, so `register_agents` should be 34. - Anindya Sinha On March 14, 2017, 6:17 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57534/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 6:17 p.m.) > > > Review request for mesos, Adam B, Anindya Sinha, Alexander Rojas, and Greg Mann. > > > Bugs: MESOS-7097 > https://issues.apache.org/jira/browse/MESOS-7097 > > > Repository: mesos > > > Description > ------- > > Added and implemented RegisterAgent ACL. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto e75e1879435f1c2bce47a86e9feebf9d051e969b > include/mesos/authorizer/authorizer.proto 736f76d552956f2351ffd40fc51d088dff83f8c8 > src/authorizer/local/authorizer.cpp be8037299601427e5d5e79f58f77eea3f89579d0 > src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f > > > Diff: https://reviews.apache.org/r/57534/diff/2/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > > --===============2076152911891286404==--