From reviews-return-57516-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 15 10:42:01 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5F92119C75 for ; Wed, 15 Mar 2017 10:42:01 +0000 (UTC) Received: (qmail 39203 invoked by uid 500); 15 Mar 2017 10:42:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 39174 invoked by uid 500); 15 Mar 2017 10:42:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 39145 invoked by uid 99); 15 Mar 2017 10:42:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Mar 2017 10:42:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7339CC0C6D; Wed, 15 Mar 2017 10:42:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id d1fEglrkQNIs; Wed, 15 Mar 2017 10:41:59 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A1D2F5FC7B; Wed, 15 Mar 2017 10:41:58 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E40B2E026E; Wed, 15 Mar 2017 10:41:57 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D29E8C4047A; Wed, 15 Mar 2017 10:41:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3068731121825519008==" MIME-Version: 1.0 Subject: Re: Review Request 57426: Added PULL_CONTAINER_IMAGE agent API call. From: Ilya Pronin To: Anand Mazumdar , Jie Yu , Vinod Kone , Gilbert Song Cc: Ilya Pronin , mesos Date: Wed, 15 Mar 2017 10:41:57 -0000 Message-ID: <20170315104157.7928.74584@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ilya Pronin X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57426/ X-Sender: Ilya Pronin References: <20170314175630.7928.95238@reviews-vm2.apache.org> In-Reply-To: <20170314175630.7928.95238@reviews-vm2.apache.org> Reply-To: Ilya Pronin X-ReviewRequest-Repository: mesos --===============3068731121825519008== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57426/ ----------------------------------------------------------- (Updated March 15, 2017, 10:41 a.m.) Review request for mesos, Anand Mazumdar, Gilbert Song, Jie Yu, and Vinod Kone. Changes ------- Rebased. Bugs: MESOS-2824 https://issues.apache.org/jira/browse/MESOS-2824 Repository: mesos Description ------- New call is intended to be used by operators for asking an agent to pre-fetch a container image for later use. Diffs (updated) ----- include/mesos/agent/agent.proto 9bac9541acd24e1123ca5dd5925e2a1381d13b4a include/mesos/v1/agent/agent.proto ea9282cf12fbe1c2ddeaa37223e4811685263734 src/slave/http.cpp 1ab6f9475af287a6ac09bc615fa466223a52c97d src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb src/slave/validation.cpp 85c43cacf1361d269c28a7fe8bd1da8615949ec8 src/tests/api_tests.cpp 29ae1bcf660fb0e03af1d2192484c9ec739f3ef6 Diff: https://reviews.apache.org/r/57426/diff/2/ Changes: https://reviews.apache.org/r/57426/diff/1-2/ Testing ------- Added `AgentAPITest.PullContainerImage` test. Ran `make check`. Verified manually by sending a call curl. Thanks, Ilya Pronin --===============3068731121825519008==--