From reviews-return-57529-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 15 12:48:46 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE761191C1 for ; Wed, 15 Mar 2017 12:48:46 +0000 (UTC) Received: (qmail 4266 invoked by uid 500); 15 Mar 2017 12:48:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 4232 invoked by uid 500); 15 Mar 2017 12:48:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 4220 invoked by uid 99); 15 Mar 2017 12:48:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Mar 2017 12:48:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 876B9C1308; Wed, 15 Mar 2017 12:48:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JrrVCbsQW93y; Wed, 15 Mar 2017 12:48:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 085405FCD1; Wed, 15 Mar 2017 12:48:42 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B7BDDE026E; Wed, 15 Mar 2017 12:48:40 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A7887C4045F; Wed, 15 Mar 2017 12:48:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2040436341211199473==" MIME-Version: 1.0 Subject: Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor. From: Alexander Rukletsov To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Vinod Kone Cc: Alexander Rukletsov , mesos Date: Wed, 15 Mar 2017 12:48:40 -0000 Message-ID: <20170315124840.4332.55275@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57596/ X-Sender: Alexander Rukletsov References: <20170314140847.3443.16391@reviews-vm2.apache.org> In-Reply-To: <20170314140847.3443.16391@reviews-vm2.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============2040436341211199473== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57596/ ----------------------------------------------------------- (Updated March 15, 2017, 12:48 p.m.) Review request for mesos, Gastón Kleiman and Vinod Kone. Changes ------- Vinod's comments. Bugs: MESOS-6906 https://issues.apache.org/jira/browse/MESOS-6906 Repository: mesos Description ------- Prior to this patch, command executor wipes TaskInfo after receiving a status update acknowledgement from the scheduler to indicate that there are no unacknowledged tasks. Keeping original TaskInfo beyond the ack can be beneficial, hence we introduce a struct TaskData that holds TaskInfo and explicit ack flag. Diffs (updated) ----- src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378 Diff: https://reviews.apache.org/r/57596/diff/2/ Changes: https://reviews.apache.org/r/57596/diff/1-2/ Testing ------- See https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov --===============2040436341211199473==--