From reviews-return-57545-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 15 14:58:29 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00FA519836 for ; Wed, 15 Mar 2017 14:58:29 +0000 (UTC) Received: (qmail 71804 invoked by uid 500); 15 Mar 2017 14:58:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 71773 invoked by uid 500); 15 Mar 2017 14:58:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 71762 invoked by uid 99); 15 Mar 2017 14:58:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Mar 2017 14:58:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A37241A0232; Wed, 15 Mar 2017 14:58:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 8DqR9s_Qpco3; Wed, 15 Mar 2017 14:58:26 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 906FA5FE2A; Wed, 15 Mar 2017 14:58:26 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8BB0DE0051; Wed, 15 Mar 2017 14:58:25 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 78DDFC4045F; Wed, 15 Mar 2017 14:58:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4022591547441839597==" MIME-Version: 1.0 Subject: Re: Review Request 56288: Improved the wording of what's logged on command health check timeouts. From: =?utf-8?q?Gast=C3=B3n_Kleiman?= To: Anand Mazumdar , haosdent huang , Vinod Kone , Alexander Rukletsov Cc: =?utf-8?q?Gast=C3=B3n_Kleiman?= , mesos Date: Wed, 15 Mar 2017 14:58:25 -0000 Message-ID: <20170315145825.4332.34936@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cnoreply=40reviews=2Eapache=2Eorg?=@reviews.apache.org, =?utf-8?q?=3E?=@reviews.apache.org X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56288/ X-Sender: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cnoreply=40reviews=2Eapache=2Eorg?= =?utf-8?q?=3E?= References: <20170216145840.31018.77062@reviews.apache.org> In-Reply-To: <20170216145840.31018.77062@reviews.apache.org> Reply-To: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cgaston=40mesosphere=2Eio=3E?=@reviews.apache.org X-ReviewRequest-Repository: mesos --===============4022591547441839597== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56288/ ----------------------------------------------------------- (Updated March 15, 2017, 2:58 p.m.) Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone. Changes ------- Rebase. Bugs: MESOS-6280 https://issues.apache.org/jira/browse/MESOS-6280 Repository: mesos Description (updated) ------- See the summary. Diffs (updated) ----- src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 Diff: https://reviews.apache.org/r/56288/diff/4/ Changes: https://reviews.apache.org/r/56288/diff/3-4/ Testing ------- None, not a functional change. Thanks, Gastón Kleiman --===============4022591547441839597==--