From reviews-return-57558-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 15 16:36:47 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4399E19DFB for ; Wed, 15 Mar 2017 16:36:47 +0000 (UTC) Received: (qmail 70595 invoked by uid 500); 15 Mar 2017 16:36:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 70564 invoked by uid 500); 15 Mar 2017 16:36:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 70445 invoked by uid 99); 15 Mar 2017 16:36:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Mar 2017 16:36:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3152A182132; Wed, 15 Mar 2017 16:36:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wSAtJXcdn1Y5; Wed, 15 Mar 2017 16:36:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A59365F23A; Wed, 15 Mar 2017 16:36:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BF45EE05C1; Wed, 15 Mar 2017 16:36:42 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 77669C404B8; Wed, 15 Mar 2017 16:36:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6255987937424053850==" MIME-Version: 1.0 Subject: Re: Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'. From: Alexander Rukletsov To: Vinod Kone , Alexander Rukletsov Cc: =?utf-8?q?Gast=C3=B3n_Kleiman?= , mesos Date: Wed, 15 Mar 2017 16:36:42 -0000 Message-ID: <20170315163642.4594.31007@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57644/ X-Sender: Alexander Rukletsov References: <20170315161853.4595.29141@reviews-vm2.apache.org> In-Reply-To: <20170315161853.4595.29141@reviews-vm2.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============6255987937424053850== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57644/#review169026 ----------------------------------------------------------- src/slave/containerizer/composing.cpp Lines 499-502 (original), 507-510 (patched) Could you please make failure messages consistent? Probably in the next RR. - Alexander Rukletsov On March 15, 2017, 4:18 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57644/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 4:18 p.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-7248 > https://issues.apache.org/jira/browse/MESOS-7248 > > > Repository: mesos > > > Description > ------- > > Implemented 'ComposingContainerizer::remove(const ContainerID&)'. > > > Diffs > ----- > > src/slave/containerizer/composing.hpp 292374aefbc70e4b9d8c81740656864dbada8e32 > src/slave/containerizer/composing.cpp 46539e4671101f9c51de563f52700e974537b472 > > > Diff: https://reviews.apache.org/r/57644/diff/2/ > > > Testing > ------- > > `make check` in Linux + manual testing > > > Thanks, > > Gastón Kleiman > > --===============6255987937424053850==--