From reviews-return-58182-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Mar 24 05:22:21 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A8A9019B5C for ; Fri, 24 Mar 2017 05:22:21 +0000 (UTC) Received: (qmail 65473 invoked by uid 500); 24 Mar 2017 05:22:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 65441 invoked by uid 500); 24 Mar 2017 05:22:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 65430 invoked by uid 99); 24 Mar 2017 05:22:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Mar 2017 05:22:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C26B31A0016; Fri, 24 Mar 2017 05:22:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id x5OuPisnbGfM; Fri, 24 Mar 2017 05:22:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 544565F58E; Fri, 24 Mar 2017 05:22:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B6315E0026; Fri, 24 Mar 2017 05:22:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 87BD2C4036F; Fri, 24 Mar 2017 05:22:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3784337809105929554==" MIME-Version: 1.0 Subject: Re: Review Request 57750: Turned off executor authentication in the ExecutorHttpApiTests. From: Anand Mazumdar To: Anand Mazumdar , Vinod Kone , Alexander Rojas Cc: Greg Mann , mesos Date: Fri, 24 Mar 2017 05:22:17 -0000 Message-ID: <20170324052217.14901.38656@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anand Mazumdar X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57750/ X-Sender: Anand Mazumdar References: <20170323161655.14900.14200@reviews-vm2.apache.org> In-Reply-To: <20170323161655.14900.14200@reviews-vm2.apache.org> Reply-To: Anand Mazumdar X-ReviewRequest-Repository: mesos --===============3784337809105929554== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57750/#review169978 ----------------------------------------------------------- src/tests/executor_http_api_tests.cpp Lines 90 (patched) Why not create a virtual overload named `CreateSlaveFlags`? There should already be other text fixtures doing the same. src/tests/executor_http_api_tests.cpp Lines 369 (patched) Move this after L374 closer to where it's used? - Anand Mazumdar On March 23, 2017, 4:16 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57750/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 4:16 p.m.) > > > Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch turns off executor authentication in the > ExecutorHttpApiTests, since authentication is not related > to the functionality they are meant to test. Since executor > tokens depend on the FrameworkID/ExecutorID/ContainerID of > the executor, it would be difficult to enable it in these > tests. > > > Diffs > ----- > > src/tests/executor_http_api_tests.cpp 13d2e1db2ffdad34dadbf2911e91938706fd4fd0 > > > Diff: https://reviews.apache.org/r/57750/diff/5/ > > > Testing > ------- > > `make check` was done to test that all existing tests succeed when executor authentication is enabled by default in the test cluster code. The ExecutorHttpApiTests are the only tests in which it has been disabled. > > > Thanks, > > Greg Mann > > --===============3784337809105929554==--