From reviews-return-58192-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Mar 24 12:54:08 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 17E4E19F2F for ; Fri, 24 Mar 2017 12:54:08 +0000 (UTC) Received: (qmail 29360 invoked by uid 500); 24 Mar 2017 12:54:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 29328 invoked by uid 500); 24 Mar 2017 12:54:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 29317 invoked by uid 99); 24 Mar 2017 12:54:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Mar 2017 12:54:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4B902C343B; Fri, 24 Mar 2017 12:54:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xacdZ2xEOm95; Fri, 24 Mar 2017 12:54:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A72D35FAD2; Fri, 24 Mar 2017 12:54:05 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D2D7BE0059; Fri, 24 Mar 2017 12:54:04 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BF96DC40481; Fri, 24 Mar 2017 12:54:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6506882342254655531==" MIME-Version: 1.0 Subject: Re: Review Request 57748: Enabled executor authentication in the tests. From: Greg Mann To: Anand Mazumdar , Vinod Kone , Alexander Rojas Cc: Greg Mann , mesos Date: Fri, 24 Mar 2017 12:54:04 -0000 Message-ID: <20170324125404.14901.81324@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57748/ X-Sender: Greg Mann References: <20170322144725.54988.31356@reviews-vm2.apache.org> In-Reply-To: <20170322144725.54988.31356@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============6506882342254655531== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57748/ ----------------------------------------------------------- (Updated March 24, 2017, 12:54 p.m.) Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone. Bugs: MESOS-6999 https://issues.apache.org/jira/browse/MESOS-6999 Repository: mesos Description ------- This patch sets the `--authenticate_http_executors` and `--executor_secret_key` flags by default in the tests, and it updates the test cluster code to load a secret generator when those flags are set. Diffs (updated) ----- src/tests/cluster.hpp 250b12fcffd035834817ff6060eb80c2cf3e0246 src/tests/cluster.cpp 15eaf4241873dc86281627db1002f9aadd26e6dc src/tests/mesos.cpp 3333c507b86075f1c24afed3fedf3e8371464d82 Diff: https://reviews.apache.org/r/57748/diff/4/ Changes: https://reviews.apache.org/r/57748/diff/3-4/ Testing ------- Testing details can be found at the end of this chain. Thanks, Greg Mann --===============6506882342254655531==--