From reviews-return-58209-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Mar 24 20:24:58 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5586199C5 for ; Fri, 24 Mar 2017 20:24:58 +0000 (UTC) Received: (qmail 35006 invoked by uid 500); 24 Mar 2017 20:24:58 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 34975 invoked by uid 500); 24 Mar 2017 20:24:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 34964 invoked by uid 99); 24 Mar 2017 20:24:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Mar 2017 20:24:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 01CD31A03C4; Fri, 24 Mar 2017 20:24:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id eZ5AnPDjXAFn; Fri, 24 Mar 2017 20:24:54 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 35CE65FB72; Fri, 24 Mar 2017 20:24:54 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 83FD3E0026; Fri, 24 Mar 2017 20:24:53 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7607AC411EB; Fri, 24 Mar 2017 20:24:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1535293651111289329==" MIME-Version: 1.0 Subject: Re: Review Request 57912: Enabled pause/resume for checks. From: Mesos Reviewbot To: Vinod Kone , Alexander Rukletsov Cc: Mesos Reviewbot , =?utf-8?q?Gast=C3=B3n_Kleiman?= , mesos Date: Fri, 24 Mar 2017 20:24:53 -0000 Message-ID: <20170324202453.28970.38465@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57912/ X-Sender: Mesos Reviewbot References: <20170324154422.28970.13961@reviews-vm2.apache.org> In-Reply-To: <20170324154422.28970.13961@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============1535293651111289329== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57912/#review170051 ----------------------------------------------------------- Patch looks great! Reviews applied: [57644, 57648, 56288, 55901, 57645, 57646, 57647, 57854, 57912] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 24, 2017, 3:44 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57912/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 3:44 p.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-7277 > https://issues.apache.org/jira/browse/MESOS-7277 > > > Repository: mesos > > > Description > ------- > > Enabled pause/resume for checks. > > > Diffs > ----- > > src/checks/checker.hpp e8af3160c9fd52ec20acf41b86bade50f4539fb1 > src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf > src/launcher/default_executor.cpp ee24531b7172dbda07999e5a1101698c395a8272 > src/launcher/executor.cpp a4bac9d932b6574eb2e1b4a27aa44eaaca6aaa62 > > > Diff: https://reviews.apache.org/r/57912/diff/1/ > > > Testing > ------- > > `make check` on Fedora 24 > > > Thanks, > > Gastón Kleiman > > --===============1535293651111289329==--