From reviews-return-58226-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Mar 24 21:55:05 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 374C519E77 for ; Fri, 24 Mar 2017 21:55:05 +0000 (UTC) Received: (qmail 36680 invoked by uid 500); 24 Mar 2017 21:55:05 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 36644 invoked by uid 500); 24 Mar 2017 21:55:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36633 invoked by uid 99); 24 Mar 2017 21:55:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Mar 2017 21:55:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5D6C5180370; Fri, 24 Mar 2017 21:55:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.001 X-Spam-Level: *** X-Spam-Status: No, score=3.001 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id p3BV8OXmzU7c; Fri, 24 Mar 2017 21:55:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C7EC85F297; Fri, 24 Mar 2017 21:55:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03779E0059; Fri, 24 Mar 2017 21:54:57 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BFA04C40481; Fri, 24 Mar 2017 21:54:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2072093937281774114==" MIME-Version: 1.0 Subject: Re: Review Request 57925: Added further tests for executor secret generation. From: Greg Mann To: Anand Mazumdar , Vinod Kone Cc: Greg Mann , mesos Date: Fri, 24 Mar 2017 21:54:56 -0000 Message-ID: <20170324215456.28970.75446@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57925/ X-Sender: Greg Mann References: <20170324215240.28971.62765@reviews-vm2.apache.org> In-Reply-To: <20170324215240.28971.62765@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============2072093937281774114== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57925/ ----------------------------------------------------------- (Updated March 24, 2017, 9:54 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6999 https://issues.apache.org/jira/browse/MESOS-6999 Repository: mesos Description ------- This patch adds two further tests for executor secret generation, `SlaveTest.RunTaskGroupReferenceTypeSecret` and `SlaveTest.RunTaskGroupFailedSecretAfterShutdown`. Diffs (updated) ----- src/tests/slave_tests.cpp c31c670b667240c4876d415aa5cf90cb34273e8a Diff: https://reviews.apache.org/r/57925/diff/3/ Changes: https://reviews.apache.org/r/57925/diff/2-3/ Testing ------- `make check` `bin/mesos-tests.sh --gtest_filter="*SlaveTest.*Secret*"` was used to check the new tests. NOTE: `SlaveTest.RunTaskGroupFailedSecretAfterShutdown` currently does not pass and needs to be debugged. Thanks, Greg Mann --===============2072093937281774114==--