From reviews-return-58239-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Mar 25 04:32:04 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6670A19B2C for ; Sat, 25 Mar 2017 04:32:04 +0000 (UTC) Received: (qmail 36285 invoked by uid 500); 25 Mar 2017 04:32:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 36254 invoked by uid 500); 25 Mar 2017 04:32:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36243 invoked by uid 99); 25 Mar 2017 04:32:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Mar 2017 04:32:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3A8E8C167C; Sat, 25 Mar 2017 04:32:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iy-JCCR0087S; Sat, 25 Mar 2017 04:32:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 81A6A5FAD2; Sat, 25 Mar 2017 04:32:01 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A83A0E008E; Sat, 25 Mar 2017 04:32:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 9493DC4004A; Sat, 25 Mar 2017 04:32:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0774693530499231034==" MIME-Version: 1.0 Subject: Re: Review Request 57743: Updated the agent to generate executor secrets. From: Greg Mann To: Anand Mazumdar , Jie Yu , Vinod Kone Cc: Greg Mann , mesos Date: Sat, 25 Mar 2017 04:32:00 -0000 Message-ID: <20170325043200.28971.37120@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57743/ X-Sender: Greg Mann References: <20170324212006.28971.34362@reviews-vm2.apache.org> In-Reply-To: <20170324212006.28971.34362@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============0774693530499231034== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57743/ ----------------------------------------------------------- (Updated March 25, 2017, 4:32 a.m.) Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Bugs: MESOS-6999 https://issues.apache.org/jira/browse/MESOS-6999 Repository: mesos Description ------- This patch updates the agent code to generate executor authentication tokens when executor authentication is enabled. For now, the generated `Secret` objects must be of `VALUE` type, and they're passed directly into the executor environment. Diffs (updated) ----- src/slave/slave.hpp e06525bf6a6596d35ae038e576f12eb96ab65a35 src/slave/slave.cpp d68d6b9a1bae79bed27babe020bf8a5d41d116bd Diff: https://reviews.apache.org/r/57743/diff/11/ Changes: https://reviews.apache.org/r/57743/diff/10-11/ Testing ------- Testing details can be found at the end of this chain. Thanks, Greg Mann --===============0774693530499231034==--