From reviews-return-58263-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Mar 25 18:26:47 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C0D341998C for ; Sat, 25 Mar 2017 18:26:47 +0000 (UTC) Received: (qmail 8638 invoked by uid 500); 25 Mar 2017 18:26:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 8602 invoked by uid 500); 25 Mar 2017 18:26:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 8591 invoked by uid 99); 25 Mar 2017 18:26:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Mar 2017 18:26:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0C4881812DA; Sat, 25 Mar 2017 18:26:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id eV0S_CBwp7zb; Sat, 25 Mar 2017 18:26:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 73F165FB02; Sat, 25 Mar 2017 18:26:45 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D71B0E0059; Sat, 25 Mar 2017 18:26:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C14E6C411EB; Sat, 25 Mar 2017 18:26:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1770037115247738976==" MIME-Version: 1.0 Subject: Re: Review Request 57750: Turned off executor authentication in the ExecutorHttpApiTests. From: Greg Mann To: Anand Mazumdar , Vinod Kone , Alexander Rojas Cc: Mesos Reviewbot , Greg Mann , mesos Date: Sat, 25 Mar 2017 18:26:44 -0000 Message-ID: <20170325182644.8807.16877@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57750/ X-Sender: Greg Mann References: <20170324130755.14900.37269@reviews-vm2.apache.org> In-Reply-To: <20170324130755.14900.37269@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============1770037115247738976== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57750/ ----------------------------------------------------------- (Updated March 25, 2017, 6:26 p.m.) Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone. Bugs: MESOS-6999 https://issues.apache.org/jira/browse/MESOS-6999 Repository: mesos Description ------- This patch turns off executor authentication in the ExecutorHttpApiTests, since authentication is not related to the functionality they are meant to test. Since executor tokens depend on the FrameworkID/ExecutorID/ContainerID of the executor, it would be difficult to enable it in these tests. Diffs (updated) ----- src/tests/executor_http_api_tests.cpp 13d2e1db2ffdad34dadbf2911e91938706fd4fd0 Diff: https://reviews.apache.org/r/57750/diff/7/ Changes: https://reviews.apache.org/r/57750/diff/6-7/ Testing ------- `make check` was done to test that all existing tests succeed when executor authentication is enabled by default in the test cluster code. The ExecutorHttpApiTests are the only tests in which it has been disabled. Thanks, Greg Mann --===============1770037115247738976==--