> On March 30, 2017, 1:33 a.m., Jie Yu wrote:
> > src/tests/resources_tests.cpp
> > Lines 1532 (patched)
> > <https://reviews.apache.org/r/57998/diff/2/?file=1680099#file1680099line1532>
> >
> > Let's split this test into smaller tests each of which test one functionality.
Take a look how we do tests for shared resources.
> >
> > I'd suggest we use a new test case name for all those tests: `ResourceProviderIDTest`
I split this into two tests, one for addition and one for subtraction.
> On March 30, 2017, 1:33 a.m., Jie Yu wrote:
> > src/tests/resources_utils.hpp
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/57998/diff/2/?file=1680100#file1680100line46>
> >
> > I would name it: `getResourcesByProviderID`
I removed this helper for now as the rewritten test does not use it anymore.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57998/#review170496
-----------------------------------------------------------
On March 31, 2017, 11:38 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57998/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 11:38 a.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an optional resource provider id to resources. In
> future changes we will introduce abstract providers of resources.
> While currently agents are implicit resource providers, later on an
> agent might use multiple resource providers. By having a provider id
> in the resource we can unambigously detect which provider contributed
> which resource.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
> src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/57998/diff/3/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|