-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57952/#review171299
-----------------------------------------------------------
src/cli_new/lib/mesos/plugins/config/main.py
Lines 77-90 (patched)
<https://reviews.apache.org/r/57952/#comment244185>
I feel that the loading of plugins should still be done inside the `main.py` file, as
it was before. This would let us do all the loading in one location, versus potentially duplicating
the plugin loading logic into `main.py` and this file.
We can still keep the config plugin, but limit its scope to reading, validating, and possibly
writing the config file.
- Joseph Wu
On March 27, 2017, 5 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57952/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 5 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7269
> https://issues.apache.org/jira/browse/MESOS-7269
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used to load and show the plugins available for the user.
>
>
> Diffs
> -----
>
> src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d
> src/cli_new/bin/settings.py PRE-CREATION
> src/cli_new/lib/mesos/plugins/config/__init__.py PRE-CREATION
> src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57952/diff/2/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>
|