-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58251/#review171316
-----------------------------------------------------------
3rdparty/libprocess/include/process/authenticator.hpp
Line 69 (original), 69 (patched)
<https://reviews.apache.org/r/58251/#comment244218>
My only concern with using either a `std::map` or a `hashmap` is that it forces clients
to have only one entry of each claim which forces us to find creative ways around this. How
about using `std::multi_map`, `std::multi_hashmap` or `hashmap<std::string, std::vector<std::string>>`?
- Alexander Rojas
On April 7, 2017, 5:26 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58251/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 5:26 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7014
> https://issues.apache.org/jira/browse/MESOS-7014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch changes the `claims` member of the authentication
> `Principal` struct from a `std::map` to a `hashmap`, so that
> we can make use of the `contains()` helper during authorization.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/authenticator.hpp 272d92117547512328c09dfc04c6ca4bf7b6b937
>
>
> Diff: https://reviews.apache.org/r/58251/diff/1/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
|