-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58095/#review171337
-----------------------------------------------------------
src/master/http.cpp
Line 3383 (original), 3385 (patched)
<https://reviews.apache.org/r/58095/#comment244245>
With the proposed changes, there's no reason to have this function in `Master::Http` and
can be move directly to `Master` IMHO.
Probably the name can be change to `activeRoles` too, since it makes more sense given
the description of _interesting roles_.
src/master/http.cpp
Lines 3453 (patched)
<https://reviews.apache.org/r/58095/#comment244242>
All the indentation of this lambda is off
src/master/http.cpp
Lines 3475 (patched)
<https://reviews.apache.org/r/58095/#comment244247>
Indentation is off.
src/master/http.cpp
Lines 3489 (patched)
<https://reviews.apache.org/r/58095/#comment244246>
Indentation is off.
- Alexander Rojas
On April 5, 2017, 4:24 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58095/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 4:24 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Benjamin Mahler, and Michael Park.
>
>
> Bugs: MESOS-4732 and MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-4732
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of generating JSON object, `Master::Http::roles()` now
> leverages `jsonify` to compute output. Also approver is taken
> out from its continuation function. This is for easier and cleaner
> implementation of framework authorization in /roles endpoint,
> see MESOS-7260.
>
>
> Diffs
> -----
>
> src/master/http.cpp 6cf9d350446d1b2d4a6e67d552217daff32657ff
> src/master/master.hpp 1b077424373d6e195e4ab29e150dedbc3f3f95ab
>
>
> Diff: https://reviews.apache.org/r/58095/diff/2/
>
>
> Testing
> -------
>
> no functional changes
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
|