> On April 7, 2017, 1:58 a.m., Vinod Kone wrote:
> > src/checks/checker.cpp
> > Lines 1081 (patched)
> > <https://reviews.apache.org/r/58196/diff/1/?file=1684610#file1684610line1081>
> >
> > Does this work even when executor is running with its own file system?
This is a good question. My understanding is that an executor always have access to `launcherDir`
because it's necessary for `mesos-containerizer` command, which we, e.g., put into `pre_exec_commands`.
However, this might not be the case for the default executor, because launch is delegated
to the agent in this case. @Jie, @Gilbert, any comments?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58196/#review171307
-----------------------------------------------------------
On April 4, 2017, 10:25 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58196/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 10:25 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-7275
> https://issues.apache.org/jira/browse/MESOS-7275
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/checks/checker.hpp fb939d85dbec2bf7e81e0c11518ccecddc5a7a11
> src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6
> src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299
> src/launcher/executor.cpp bc69beb884d95d1616b2a3d928cdbf00f70f7c88
> src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422
>
>
> Diff: https://reviews.apache.org/r/58196/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS 10.11.6 and various linux variants.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
|