mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 58196: Implemented TCP check support in command and default executors.
Date Fri, 07 Apr 2017 15:25:35 GMT 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58196/
-----------------------------------------------------------

(Updated April 7, 2017, 3:25 p.m.)


Review request for mesos, Gastón Kleiman and Vinod Kone.


Changes
-------

Addressed some comments.


Bugs: MESOS-7275
    https://issues.apache.org/jira/browse/MESOS-7275


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/checks/checker.hpp fb939d85dbec2bf7e81e0c11518ccecddc5a7a11 
  src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 
  src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299 
  src/launcher/executor.cpp d14fbfb65d1cc44c954c8cdbbf36d7ddf6ede19e 
  src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422 


Diff: https://reviews.apache.org/r/58196/diff/2/

Changes: https://reviews.apache.org/r/58196/diff/1-2/


Testing
-------

make check on Mac OS 10.11.6 and various linux variants.


Thanks,

Alexander Rukletsov
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message