> On April 26, 2017, 5:13 p.m., Chun-Hung Hsiao wrote:
> > src/uri/fetchers/docker.cpp
> > Lines 542 (patched)
> > <https://reviews.apache.org/r/58747/diff/2/?file=1700766#file1700766line542>
> >
> > Should we also trigger the failure when `!contentType.isSome()`?
Thought about that. Let's keep it as the old semantic and rely on Ilya's schema 2 support
to make that change.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58747/#review173136
-----------------------------------------------------------
On April 26, 2017, 4:12 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58747/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 4:12 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-7272
> https://issues.apache.org/jira/browse/MESOS-7272
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This check was introduced from this patch:
> https://reviews.apache.org/r/53848/
>
> The check on registry v2 schema 1 is incorrect. It does not work
> for registries that are older version < 2.3, because the ContentType
> header may be something like this "application/json; charset=utf-8".
> The check missed a note from docker registry spec that
> "application/json" will also be accepted for schema 1.
>
> Depending on the docker registry spec doc, docker support the
> following three media type for V2 schema 1 manifest:
> 1. application/vnd.docker.distribution.manifest.v1+json
> 2. application/vnd.docker.distribution.manifest.v1+prettyjws
> 3. application/json
> For more details, see:
> https://docs.docker.com/registry/spec/manifest-v2-1/
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90
>
>
> Diff: https://reviews.apache.org/r/58747/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
|