-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review173277
-----------------------------------------------------------
Fix it, then Ship it!
support/test-upgrade.py
Lines 342-343 (patched)
<https://reviews.apache.org/r/58357/#comment246314>
Could you add an extra newline (or two?) at the end of this print statement? Currently,
the output in between interations has no newline separating one run from the next:
```
Test case 4 (Run of next setup)
##### Starting mesos 1.3.0 cpp-test-framework #####
Waiting for mesos 1.3.0 cpp-test-framework to complete (10 sec max)...
Run ['/mnt/src/mesos/build/src/test-framework', '--master=127.0.0.1:5050'], output: /tmp/tmpMNDhg3
mesos 1.3.0 cpp-test-framework succeeded with mesos 1.3.0 master and mesos 1.3.0 agent
Upgrade test succeeded for framework cpp-test-framework from mesos 1.2.0 to mesos 1.3.0
Running upgrade test from mesos 1.2.0 to mesos 1.3.0 for framework java-test-framework
+--------------+----------------+----------------+---------------+
| Test case | Framework | Master | Agent |
+--------------+----------------+----------------+---------------+
| #1 | mesos 1.2.0 | mesos 1.2.0 | mesos 1.2.0 |
| #2 | mesos 1.2.0 | mesos 1.3.0 | mesos 1.2.0 |
| #3 | mesos 1.2.0 | mesos 1.3.0 | mesos 1.3.0 |
| #4 | mesos 1.3.0 | mesos 1.3.0 | mesos 1.3.0 |
+--------------+----------------+----------------+---------------+
NOTE: live denotes that master process keeps running from previous case.
```
- Greg Mann
On April 27, 2017, 5:58 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 5:58 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/4/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
|