> On April 25, 2017, 5:59 p.m., Benjamin Mahler wrote:
> > src/tests/upgrade_tests.cpp
> > Lines 537-539 (patched)
> > <https://reviews.apache.org/r/58689/diff/1/?file=1698681#file1698681line537>
> >
> > This comment seems to be inconsistent with what the test is doing?
> >
> > Also, this doesn't look like an upgrade test, should we make it a master test?
>
> Michael Park wrote:
> Updated the comment to more accurately reflect the test.
>
> I was considering this to be a kind of an upgrade test, in the sense that
> we're upgrading the framework from one config to another.
>
> I'm not sure if we have some clear criteria for what qualifies as an upgrade test.
>
> But I'm also fine with this living in master test.
>
> Benjamin Mahler wrote:
> Well, my intention was described at the top of the file:
>
> ```
> // This file contains upgrade integration tests. Note that tests
> // in this file can only "spoof" an old version of a component,
> // since these run against the current version of the repository.
> // The long term plan for integration tests is to checkout
> // different releases of the repository and run components from
> // different releases against each other.
> ```
Ah, sorry about that. Moved to `master_tests.cpp`
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58689/#review172968
-----------------------------------------------------------
On April 26, 2017, 7:54 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58689/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 7:54 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.
>
>
> Bugs: MESOS-7323
> https://issues.apache.org/jira/browse/MESOS-7323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-7323: Made `addSlave` not activate any frameworks.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa
> src/tests/upgrade_tests.cpp b5a28b5161d896dff250b8ad012c8aac91c3f861
>
>
> Diff: https://reviews.apache.org/r/58689/diff/3/
>
>
> Testing
> -------
>
> `make check` and added a test.
>
>
> Thanks,
>
> Michael Park
>
>
|