James Peach |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Wed, 19 Apr, 17:25 |
Anindya Sinha |
Re: Review Request 58487: Fix allocation quantities when shared resources are removed. |
Wed, 19 Apr, 17:40 |
Andrew Schwartzmeyer |
Re: Review Request 58447: CMake: Cleaned up 3rdparty dependencies. |
Wed, 19 Apr, 18:18 |
Andrew Schwartzmeyer |
Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly. |
Wed, 19 Apr, 18:18 |
Andrew Schwartzmeyer |
Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake. |
Wed, 19 Apr, 18:20 |
Andrew Schwartzmeyer |
Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake. |
Wed, 19 Apr, 18:21 |
Andrew Schwartzmeyer |
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows. |
Wed, 19 Apr, 18:22 |
Zhitao Li |
Re: Review Request 58359: Update Mesos build library to use protobuf 3.2.0. |
Wed, 19 Apr, 18:28 |
Mesos Reviewbot |
Re: Review Request 58512: Avoid a crash in HTTP decoder. |
Wed, 19 Apr, 18:37 |
Neil Conway |
Re: Review Request 58533: Added a benchmark test for hierarchical sorter. |
Wed, 19 Apr, 19:04 |
James Peach |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Wed, 19 Apr, 20:14 |
Mesos Reviewbot |
Re: Review Request 58357: Support more test frameworks in test-upgrade script. |
Wed, 19 Apr, 20:40 |
Mesos Reviewbot |
Re: Review Request 58361: Updated LICENSE information for protobuf 3.2.0. |
Wed, 19 Apr, 21:45 |
James Peach |
Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask. |
Wed, 19 Apr, 22:04 |
James Peach |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Wed, 19 Apr, 22:05 |
James Peach |
Re: Review Request 58304: Remove unnecessary hashmap lookups. |
Wed, 19 Apr, 22:05 |
James Peach |
Re: Review Request 58304: Remove unnecessary hashmap lookups. |
Wed, 19 Apr, 22:07 |
Zhitao Li |
Re: Review Request 58515: Update 3rdparty build to support protobuf 3.2.0. |
Wed, 19 Apr, 22:25 |
Neil Conway |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Wed, 19 Apr, 22:31 |
Benjamin Mahler |
Review Request 58545: Removed NOTE about incomplete implementation of FrameworkInfo.roles. |
Wed, 19 Apr, 22:32 |
Neil Conway |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Wed, 19 Apr, 22:34 |
James Peach |
Re: Review Request 58304: Remove unnecessary hashmap lookups. |
Wed, 19 Apr, 22:48 |
James Peach |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Wed, 19 Apr, 22:49 |
James Peach |
Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask. |
Wed, 19 Apr, 22:49 |
Neil Conway |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Wed, 19 Apr, 23:06 |
Mesos Reviewbot |
Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask. |
Wed, 19 Apr, 23:38 |
Benjamin Mahler |
Re: Review Request 58355: Removed unnecessary Registry copying. |
Wed, 19 Apr, 23:41 |
James Peach |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Thu, 20 Apr, 00:03 |
James Peach |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Thu, 20 Apr, 00:08 |
Neil Conway |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Thu, 20 Apr, 00:10 |
Mesos Reviewbot |
Re: Review Request 58545: Removed NOTE about incomplete implementation of FrameworkInfo.roles. |
Thu, 20 Apr, 01:34 |
Benjamin Mahler |
Review Request 58547: Fixed an inaccurately named table header in the agent webui page. |
Thu, 20 Apr, 01:53 |
Benjamin Mahler |
Review Request 58548: Fixed inconsistent terminology for 'Used' vs 'Allocated' in the webui. |
Thu, 20 Apr, 01:53 |
Benjamin Mahler |
Review Request 58549: Updated agent webui page to display allocated and available resources. |
Thu, 20 Apr, 01:53 |
Jay Guo |
Re: Review Request 58545: Removed NOTE about incomplete implementation of FrameworkInfo.roles. |
Thu, 20 Apr, 02:26 |
Jay Guo |
Review Request 58552: Resolved a TODO of MULTI_ROLE. |
Thu, 20 Apr, 03:00 |
Mesos Reviewbot |
Re: Review Request 58549: Updated agent webui page to display allocated and available resources. |
Thu, 20 Apr, 03:33 |
Jay Guo |
Re: Review Request 58533: Added a benchmark test for hierarchical sorter. |
Thu, 20 Apr, 03:54 |
Jay Guo |
Re: Review Request 58533: Added a benchmark test for hierarchical sorter. |
Thu, 20 Apr, 03:54 |
Mesos Reviewbot |
Re: Review Request 58552: Resolved a TODO of MULTI_ROLE. |
Thu, 20 Apr, 05:29 |
Mesos Reviewbot |
Re: Review Request 58533: Added a benchmark test for hierarchical sorter. |
Thu, 20 Apr, 06:40 |
Andy Pang |
Re: Review Request 58287: Print corresponding address when socket shutdown. |
Thu, 20 Apr, 09:09 |
Michael Park |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Thu, 20 Apr, 09:35 |
Andy Pang |
Review Request 58557: Print failure reason when socket accept failed. |
Thu, 20 Apr, 09:35 |
Michael Park |
Re: Review Request 58508: Introduced method `Resources::inheritable` to aggregate reservations. |
Thu, 20 Apr, 09:39 |
Zhongbo Tian |
Review Request 58560: Enabling automatic protobuf flag parsing (for stout). |
Thu, 20 Apr, 10:18 |
Zhongbo Tian |
Review Request 58561: Enabling automatic protobuf flag parsing (for mesos). |
Thu, 20 Apr, 10:21 |
Gastón Kleiman |
Re: Review Request 58194: Hardened HTTP check tests. |
Thu, 20 Apr, 11:31 |
Andy Pang |
Re: Review Request 58287: Print corresponding address when socket shutdown. |
Thu, 20 Apr, 11:34 |
Gastón Kleiman |
Re: Review Request 58196: Implemented TCP check support in command and default executors. |
Thu, 20 Apr, 11:53 |
Mesos Reviewbot |
Re: Review Request 58557: Print failure reason when socket accept failed. |
Thu, 20 Apr, 12:29 |
Mesos Reviewbot |
Re: Review Request 58561: Enabling automatic protobuf flag parsing (for mesos). |
Thu, 20 Apr, 13:34 |
Jeff Coffler |
Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake. |
Thu, 20 Apr, 15:15 |
Jeff Coffler |
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows. |
Thu, 20 Apr, 15:18 |
Mesos Reviewbot |
Re: Review Request 58287: Print corresponding address when socket shutdown. |
Thu, 20 Apr, 15:28 |
Anand Mazumdar |
Re: Review Request 58512: Avoid a crash in HTTP decoder. |
Thu, 20 Apr, 16:06 |
Jay Guo |
Re: Review Request 58508: Introduced method `Resources::inheritable` to aggregate reservations. |
Thu, 20 Apr, 16:18 |
Neil Conway |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Thu, 20 Apr, 16:59 |
Neil Conway |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Thu, 20 Apr, 17:01 |
Andrew Schwartzmeyer |
Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake. |
Thu, 20 Apr, 17:11 |
Andrew Schwartzmeyer |
Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows. |
Thu, 20 Apr, 17:11 |
Anindya Sinha |
Review Request 58580: Mark decoder as failed when http parsing failed for any reason. |
Thu, 20 Apr, 17:18 |
Anindya Sinha |
Re: Review Request 58512: Avoid a crash in HTTP decoder. |
Thu, 20 Apr, 17:18 |
Anindya Sinha |
Re: Review Request 58512: Avoid a crash in HTTP decoder. |
Thu, 20 Apr, 17:18 |
Anand Mazumdar |
Re: Review Request 58580: Mark decoder as failed when http parsing failed for any reason. |
Thu, 20 Apr, 17:19 |
Anand Mazumdar |
Re: Review Request 58512: Avoid a crash in HTTP decoder. |
Thu, 20 Apr, 17:21 |
Anindya Sinha |
Re: Review Request 58580: Mark decoder as failed when http parsing failed for any reason. |
Thu, 20 Apr, 17:40 |
Anindya Sinha |
Re: Review Request 58512: Avoid a crash in HTTP decoder. |
Thu, 20 Apr, 17:40 |
James Peach |
Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles. |
Thu, 20 Apr, 18:04 |
Neil Conway |
Re: Review Request 57516: Updated CHANGELOG for hierarchical roles. |
Thu, 20 Apr, 18:14 |
Neil Conway |
Review Request 58584: Disabled support for quota on nested roles. |
Thu, 20 Apr, 18:15 |
Jiang Yan Xu |
Re: Review Request 58486: Fixed a race in `updateAllocation()` on DESTORY of a shared volume. |
Thu, 20 Apr, 18:17 |
Neil Conway |
Re: Review Request 58584: Disabled support for setting quota on nested roles. |
Thu, 20 Apr, 18:18 |
Jiang Yan Xu |
Re: Review Request 58487: Fix allocation quantities when shared resources are removed. |
Thu, 20 Apr, 18:19 |
Mesos Reviewbot |
Re: Review Request 58512: Avoid a crash in HTTP decoder. |
Thu, 20 Apr, 18:20 |
Michael Park |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Thu, 20 Apr, 20:29 |
Neil Conway |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Thu, 20 Apr, 20:40 |
Anindya Sinha |
Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles. |
Thu, 20 Apr, 21:10 |
James Peach |
Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator. |
Thu, 20 Apr, 21:15 |
Greg Mann |
Re: Review Request 58357: Support more test frameworks in test-upgrade script. |
Thu, 20 Apr, 21:40 |
James Peach |
Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles. |
Thu, 20 Apr, 22:39 |
Neil Conway |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Fri, 21 Apr, 03:27 |
Neil Conway |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Fri, 21 Apr, 03:55 |
Neil Conway |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Fri, 21 Apr, 04:32 |
Jiang Yan Xu |
Re: Review Request 57535: Applied RegisterAgent ACL to the master. |
Fri, 21 Apr, 04:53 |
Jiang Yan Xu |
Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL. |
Fri, 21 Apr, 05:10 |
Jiang Yan Xu |
Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL. |
Fri, 21 Apr, 05:10 |
Michael Park |
Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. |
Fri, 21 Apr, 05:13 |
Jay Guo |
Re: Review Request 58584: Disabled support for setting quota on nested roles. |
Fri, 21 Apr, 06:01 |
Zhongbo Tian |
Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem. |
Fri, 21 Apr, 06:59 |
Zhongbo Tian |
Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem. |
Fri, 21 Apr, 07:02 |
Benjamin Bannier |
Re: Review Request 58545: Removed NOTE about incomplete implementation of FrameworkInfo.roles. |
Fri, 21 Apr, 07:26 |
Mesos Reviewbot |
Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem. |
Fri, 21 Apr, 08:08 |
James Peach |
Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage. |
Fri, 21 Apr, 16:56 |
James Peach |
Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask. |
Fri, 21 Apr, 16:57 |
James Peach |
Review Request 58621: Add some parameter validation to RegisterSlaveMessage. |
Fri, 21 Apr, 16:57 |
James Peach |
Re: Review Request 58621: Add some parameter validation to RegisterSlaveMessage. |
Fri, 21 Apr, 16:57 |
James Peach |
Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask. |
Fri, 21 Apr, 17:04 |
James Peach |
Review Request 58622: Document that master message validation is best effort. |
Fri, 21 Apr, 17:05 |
Jiang Yan Xu |
Re: Review Request 57963: Metrics for used resources should incorporate shared resources. |
Fri, 21 Apr, 17:37 |