From reviews-return-58594-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 3 09:06:30 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E2B519FA7 for ; Mon, 3 Apr 2017 09:06:30 +0000 (UTC) Received: (qmail 71683 invoked by uid 500); 3 Apr 2017 09:06:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 71648 invoked by uid 500); 3 Apr 2017 09:06:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 71633 invoked by uid 99); 3 Apr 2017 09:06:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Apr 2017 09:06:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BA1A1C6627; Mon, 3 Apr 2017 09:06:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id N84QzewSrzhP; Mon, 3 Apr 2017 09:06:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CC12B5F23A; Mon, 3 Apr 2017 09:06:28 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 77F0DE0012; Mon, 3 Apr 2017 09:06:28 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 67AD6C411EC; Mon, 3 Apr 2017 09:06:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6747380192021512944==" MIME-Version: 1.0 Subject: Re: Review Request 58084: Adjust `using` style in a few places. From: Benjamin Bannier To: Benjamin Bannier Cc: Neil Conway , mesos Date: Mon, 03 Apr 2017 09:06:28 -0000 Message-ID: <20170403090628.51341.8273@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58084/ X-Sender: Benjamin Bannier References: <20170330164918.31070.79262@reviews-vm2.apache.org> In-Reply-To: <20170330164918.31070.79262@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============6747380192021512944== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58084/#review170831 ----------------------------------------------------------- See my comment at https://reviews.apache.org/r/58043/. - Benjamin Bannier On March 30, 2017, 6:49 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58084/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 6:49 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > When an identifier is used many times in an implementation file, we > typically add a `using` statement for that identifier. > > > Diffs > ----- > > src/common/build.cpp a87d2cf5463b13d59cf548e7e0edfca600e256b1 > src/slave/container_loggers/lib_logrotate.cpp ae5d0acdaf64304675ee0f144c8d0c0988ba9112 > src/tests/cluster.cpp 7f09a0c8b93e8fa945e7b2c809624b12e61b4198 > src/tests/containerizer/composing_containerizer_tests.cpp 934824c61a857bdc4d2d8ef790b64a33d14eab9f > > > Diff: https://reviews.apache.org/r/58084/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > > --===============6747380192021512944==--