From reviews-return-58598-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 3 09:25:48 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF64A1909B for ; Mon, 3 Apr 2017 09:25:48 +0000 (UTC) Received: (qmail 22396 invoked by uid 500); 3 Apr 2017 09:25:48 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22370 invoked by uid 500); 3 Apr 2017 09:25:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22359 invoked by uid 99); 3 Apr 2017 09:25:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Apr 2017 09:25:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 232F01800B9; Mon, 3 Apr 2017 09:25:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id P44eRbGiGf9u; Mon, 3 Apr 2017 09:25:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F12E95F24E; Mon, 3 Apr 2017 09:25:45 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A3F12E0185; Mon, 3 Apr 2017 09:25:45 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 944B4C411EC; Mon, 3 Apr 2017 09:25:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2539850489449333885==" MIME-Version: 1.0 Subject: Re: Review Request 57999: Made Path and Mount root optional in Resource.DiskInfo.Source. From: Benjamin Bannier To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , mesos Date: Mon, 03 Apr 2017 09:25:45 -0000 Message-ID: <20170403092545.51342.11535@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57999/ X-Sender: Benjamin Bannier References: <20170330130235.10619.97203@reviews-vm2.apache.org> In-Reply-To: <20170330130235.10619.97203@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============2539850489449333885== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 30, 2017, 3:02 p.m., Jan Schlicht wrote: > > There's also some validation in `resources.cpp` (`validate` in line 739) that needs to be updated to support missing paths. Good point. Fixed in both v0 and v1 now. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57999/#review170570 ----------------------------------------------------------- On March 31, 2017, 11:38 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57999/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 11:38 a.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7312 > https://issues.apache.org/jira/browse/MESOS-7312 > > > Repository: mesos > > > Description > ------- > > This commit is preparation for future changes where path or mount > roots might be calculated lazily, i.e., not known early enough > anymore. > > > Diffs > ----- > > include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac > include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c > src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a > src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f > src/slave/slave.cpp 1c164c9d2e22868ddec80d26a31504333f483633 > src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 > > > Diff: https://reviews.apache.org/r/57999/diff/3/ > > > Testing > ------- > > make check (OS X, Fedora25) > > > Thanks, > > Benjamin Bannier > > --===============2539850489449333885==--