From reviews-return-58600-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 3 09:29:28 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BD180190BD for ; Mon, 3 Apr 2017 09:29:28 +0000 (UTC) Received: (qmail 29070 invoked by uid 500); 3 Apr 2017 09:29:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 29036 invoked by uid 500); 3 Apr 2017 09:29:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 29025 invoked by uid 99); 3 Apr 2017 09:29:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Apr 2017 09:29:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 001C1C0040; Mon, 3 Apr 2017 09:29:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id RAGBlhbtZiBe; Mon, 3 Apr 2017 09:29:26 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0AE8D5F397; Mon, 3 Apr 2017 09:29:26 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6270DE0185; Mon, 3 Apr 2017 09:29:25 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 52AE9C411EC; Mon, 3 Apr 2017 09:29:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5329504825337698619==" MIME-Version: 1.0 Subject: Re: Review Request 58048: Added id to Resource.DiskInfo. From: Jan Schlicht To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , mesos Date: Mon, 03 Apr 2017 09:29:25 -0000 Message-ID: <20170403092925.51342.85278@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jan Schlicht X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58048/ X-Sender: Jan Schlicht X-ReviewBoard-ShipIt: 1 References: <20170331093808.31070.65415@reviews-vm2.apache.org> In-Reply-To: <20170331093808.31070.65415@reviews-vm2.apache.org> Reply-To: Jan Schlicht X-ReviewRequest-Repository: mesos --===============5329504825337698619== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review170832 ----------------------------------------------------------- Fix it, then Ship it! src/tests/mesos.hpp Line 1356 (original), 1374 (patched) Please add a line break after `<` to remove "jaggedness", as it's done, e.g., in `createTaskGroupInfo` above. - Jan Schlicht On March 31, 2017, 11:38 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58048/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 11:38 a.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7312 > https://issues.apache.org/jira/browse/MESOS-7312 > > > Repository: mesos > > > Description > ------- > > Ids will allow to create distinguishable resources, e.g., of RAW or > BLOCK type. > > > Diffs > ----- > > include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac > include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c > src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a > src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2 > src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d > src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 > > > Diff: https://reviews.apache.org/r/58048/diff/2/ > > > Testing > ------- > > make check (OS X, Fedora25) > > > Thanks, > > Benjamin Bannier > > --===============5329504825337698619==--