From reviews-return-58609-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 3 13:24:53 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B8EF219D0F for ; Mon, 3 Apr 2017 13:24:53 +0000 (UTC) Received: (qmail 74500 invoked by uid 500); 3 Apr 2017 13:24:53 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74466 invoked by uid 500); 3 Apr 2017 13:24:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74455 invoked by uid 99); 3 Apr 2017 13:24:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Apr 2017 13:24:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 07175C1FC8; Mon, 3 Apr 2017 13:24:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4lM0wHBkwNRs; Mon, 3 Apr 2017 13:24:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 55B635F397; Mon, 3 Apr 2017 13:24:51 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A4D11E0185; Mon, 3 Apr 2017 13:24:50 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 73785C411EC; Mon, 3 Apr 2017 13:24:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6952651666427776541==" MIME-Version: 1.0 Subject: Re: Review Request 58146: Added infrastructure for unit tests in the new python-based CLI. From: Mesos Reviewbot To: Kevin Klues Cc: Mesos Reviewbot , Armand Grillet , mesos Date: Mon, 03 Apr 2017 13:24:50 -0000 Message-ID: <20170403132450.51342.49754@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58146/ X-Sender: Mesos Reviewbot References: <20170403122431.51342.70019@reviews-vm2.apache.org> In-Reply-To: <20170403122431.51342.70019@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/cli_new/bin/mesos-cli-tests X-ReviewBoard-Diff-For: src/cli_new/tests/main.py Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============6952651666427776541== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58146/#review170871 ----------------------------------------------------------- Patch looks great! Reviews applied: [58146] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 3, 2017, 12:24 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58146/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 12:24 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-6032 > https://issues.apache.org/jira/browse/MESOS-6032 > > > Repository: mesos > > > Description > ------- > > This is the base to develop unit tests for the Mesos CLI. > > > Diffs > ----- > > src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af > src/cli_new/bin/mesos-cli-tests PRE-CREATION > src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf > src/cli_new/tests/main.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/58146/diff/1/ > > > Testing > ------- > > $ cd src/cli_new > $ ./bootstrap > $ source activate > > (mesos-cli) $ mesos-cli-tests > > > Thanks, > > Armand Grillet > > --===============6952651666427776541==--