From reviews-return-58651-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 4 14:49:57 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0A1D719743 for ; Tue, 4 Apr 2017 14:49:57 +0000 (UTC) Received: (qmail 62073 invoked by uid 500); 4 Apr 2017 14:49:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 62053 invoked by uid 500); 4 Apr 2017 14:49:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 61799 invoked by uid 99); 4 Apr 2017 14:49:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Apr 2017 14:49:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5DB5DC6A18; Tue, 4 Apr 2017 14:49:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 65M7D2bGhNzY; Tue, 4 Apr 2017 14:49:54 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5BCCB5FC90; Tue, 4 Apr 2017 14:49:54 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 04995E0041; Tue, 4 Apr 2017 14:49:54 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E9BEFC4047E; Tue, 4 Apr 2017 14:49:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7882370172302741001==" MIME-Version: 1.0 Subject: Re: Review Request 57998: Added ResourceProviderID to Resource protos. From: Jan Schlicht To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , Qian Zhang , mesos Date: Tue, 04 Apr 2017 14:49:53 -0000 Message-ID: <20170404144953.29825.79095@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jan Schlicht X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57998/ X-Sender: Jan Schlicht References: <20170404144039.29826.82225@reviews-vm2.apache.org> In-Reply-To: <20170404144039.29826.82225@reviews-vm2.apache.org> Reply-To: Jan Schlicht X-ReviewRequest-Repository: mesos --===============7882370172302741001== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 4, 2017, 4:40 p.m., Jan Schlicht wrote: > > Sorry for not noticing this earlier: Because I've just run into this, could you also add a `std::hash` specialization for `ResourceProviderID` in `type_utils.hpp`? This will allow us to use `ResourceProviderID` as key in a hashmap. But I could also create a follow-up review for that. There's also `operator==` in `type_utils.hpp` which needs to be implemented. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57998/#review170970 ----------------------------------------------------------- On March 31, 2017, 11:38 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57998/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 11:38 a.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7312 > https://issues.apache.org/jira/browse/MESOS-7312 > > > Repository: mesos > > > Description > ------- > > This patch adds an optional resource provider id to resources. In > future changes we will introduce abstract providers of resources. > While currently agents are implicit resource providers, later on an > agent might use multiple resource providers. By having a provider id > in the resource we can unambigously detect which provider contributed > which resource. > > > Diffs > ----- > > include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac > include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c > src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a > src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d > src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff > src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 > > > Diff: https://reviews.apache.org/r/57998/diff/3/ > > > Testing > ------- > > make check (OS X, Fedora25) > > > Thanks, > > Benjamin Bannier > > --===============7882370172302741001==--