----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57925/#review171292 ----------------------------------------------------------- Ship it! Ship It! - Vinod Kone On April 5, 2017, 10:34 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57925/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 10:34 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch adds two further tests for executor secret > generation, `SlaveTest.RunTaskGroupReferenceTypeSecret` > and `SlaveTest.RunTaskGroupFailedSecretAfterShutdown`. > > > Diffs > ----- > > src/tests/slave_tests.cpp cd769687e0f161512c0114ef4651508c31f51639 > > > Diff: https://reviews.apache.org/r/57925/diff/8/ > > > Testing > ------- > > `make check` > > `bin/mesos-tests.sh --gtest_filter="SlaveTest.*Secret*" --gtest_repeat=-1 --gtest_break_on_failure` was used to check the new tests. > > > Thanks, > > Greg Mann > >