From reviews-return-58805-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 7 03:26:27 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C4C94188F2 for ; Fri, 7 Apr 2017 03:26:27 +0000 (UTC) Received: (qmail 36470 invoked by uid 500); 7 Apr 2017 03:26:27 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 36432 invoked by uid 500); 7 Apr 2017 03:26:27 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36421 invoked by uid 99); 7 Apr 2017 03:26:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Apr 2017 03:26:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D7794C2411; Fri, 7 Apr 2017 03:26:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id HE8HC8xEt_H9; Fri, 7 Apr 2017 03:26:24 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 55D335F2FE; Fri, 7 Apr 2017 03:26:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B3ABAE00B4; Fri, 7 Apr 2017 03:26:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 89F82C405B5; Fri, 7 Apr 2017 03:26:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2151807676053736218==" MIME-Version: 1.0 Subject: Review Request 58251: Changed 'Principal.claims' to a hashmap. From: Greg Mann To: Adam B , Alexander Rojas , Till Toenshoff , Vinod Kone Cc: Greg Mann , mesos Date: Fri, 07 Apr 2017 03:26:22 -0000 Message-ID: <20170407032622.2051.28244@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58251/ X-Sender: Greg Mann Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============2151807676053736218== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58251/ ----------------------------------------------------------- Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone. Bugs: MESOS-7014 https://issues.apache.org/jira/browse/MESOS-7014 Repository: mesos Description ------- This patch changes the `claims` member of the authentication `Principal` struct from a `std::map` to a `hashmap`, so that we can make use of the `contains()` helper during authorization. Diffs ----- 3rdparty/libprocess/include/process/authenticator.hpp 272d92117547512328c09dfc04c6ca4bf7b6b937 Diff: https://reviews.apache.org/r/58251/diff/1/ Testing ------- Testing details can be found at the end of this chain. Thanks, Greg Mann --===============2151807676053736218==--