From reviews-return-58841-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 7 15:08:53 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC96418696 for ; Fri, 7 Apr 2017 15:08:53 +0000 (UTC) Received: (qmail 1334 invoked by uid 500); 7 Apr 2017 15:08:53 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 1303 invoked by uid 500); 7 Apr 2017 15:08:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 1292 invoked by uid 99); 7 Apr 2017 15:08:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Apr 2017 15:08:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EF817C0750; Fri, 7 Apr 2017 15:08:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id kWrGe_cvr-JM; Fri, 7 Apr 2017 15:08:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CFFF85FBFC; Fri, 7 Apr 2017 15:08:51 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7C9FDE02AA; Fri, 7 Apr 2017 15:08:51 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6E0F9C40414; Fri, 7 Apr 2017 15:08:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6850751339583704477==" MIME-Version: 1.0 Subject: Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch). From: haosdent huang To: haosdent huang , Alexander Rukletsov Cc: Deshi Xiao , mesos Date: Fri, 07 Apr 2017 15:08:51 -0000 Message-ID: <20170407150851.64842.26918@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: haosdent huang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58200/ X-Sender: haosdent huang References: <20170405233506.56252.73341@reviews-vm2.apache.org> In-Reply-To: <20170405233506.56252.73341@reviews-vm2.apache.org> Reply-To: haosdent huang X-ReviewRequest-Repository: mesos --===============6850751339583704477== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58200/#review171353 ----------------------------------------------------------- src/slave/containerizer/docker.cpp Lines 361 (patched) Got this error ``` Failed to enter the net namespace of task (pid: '78851'): Operation not permitted ``` Need to add capacity. - haosdent huang On April 5, 2017, 11:35 p.m., Deshi Xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58200/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 11:35 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Bugs: MESOS-7210 > https://issues.apache.org/jira/browse/MESOS-7210 > > > Repository: mesos > > > Description > ------- > > Becuase MESOS HTTP checks doesn't work when mesos runs with > --docker_mesos_image ( pid namespace mismatch ).So let docker > executor run with container add host pid mapping(--pid=host) > > > Diffs > ----- > > src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e > > > Diff: https://reviews.apache.org/r/58200/diff/1/ > > > Testing > ------- > > first testing : https://gist.github.com/xiaods/c5a11e3ab51e89a9609edc2c477f7ea8 > > > Thanks, > > Deshi Xiao > > --===============6850751339583704477==--