From reviews-return-58854-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 7 20:19:59 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C9EC188F6 for ; Fri, 7 Apr 2017 20:19:59 +0000 (UTC) Received: (qmail 83408 invoked by uid 500); 7 Apr 2017 20:19:58 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 83371 invoked by uid 500); 7 Apr 2017 20:19:58 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83360 invoked by uid 99); 7 Apr 2017 20:19:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Apr 2017 20:19:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 32EB21A0011; Fri, 7 Apr 2017 20:19:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id zxIZ1Z7YNruE; Fri, 7 Apr 2017 20:19:54 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5345F5F1B3; Fri, 7 Apr 2017 20:19:54 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AEA06E02AA; Fri, 7 Apr 2017 20:19:53 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 9FA46C406CC; Fri, 7 Apr 2017 20:19:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1529506286777540634==" MIME-Version: 1.0 Subject: Re: Review Request 57972: Added base stout Environment class to mesos-tests Environment class. From: Joseph Wu To: Joseph Wu Cc: John Kordich , mesos Date: Fri, 07 Apr 2017 20:19:53 -0000 Message-ID: <20170407201953.14957.1652@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57972/ X-Sender: Joseph Wu References: <20170405190856.56252.12300@reviews-vm2.apache.org> In-Reply-To: <20170405190856.56252.12300@reviews-vm2.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============1529506286777540634== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57972/#review171377 ----------------------------------------------------------- src/tests/environment.cpp Lines 721-722 (original), 86-90 (patched) Instead of moving all those test filters into the header file, why not do this? ``` Environment::Environment(const Flags& _flags) : stout::internal::tests::Environment( std::vector>{ std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared(), std::make_shared()}), flags(_flags) ``` - Joseph Wu On April 5, 2017, 12:08 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57972/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 12:08 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-6731 > https://issues.apache.org/jira/browse/MESOS-6731 > > > Repository: mesos > > > Description > ------- > > Added base stout Environment class to mesos-tests Environment class. > > > Diffs > ----- > > src/tests/environment.hpp 06b6d54fc76b327e3e26914eb61c16619a36de42 > src/tests/environment.cpp e3cff1847c44bb06bbe898211bfca35cf851217a > src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043 > > > Diff: https://reviews.apache.org/r/57972/diff/2/ > > > Testing > ------- > > Ran make check on Linux and the tests on Windows. > > > Thanks, > > John Kordich > > --===============1529506286777540634==--