From reviews-return-59716-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 27 07:09:07 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A98F2199D5 for ; Thu, 27 Apr 2017 07:09:07 +0000 (UTC) Received: (qmail 81173 invoked by uid 500); 27 Apr 2017 07:09:07 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 81143 invoked by uid 500); 27 Apr 2017 07:09:07 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81129 invoked by uid 99); 27 Apr 2017 07:09:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 07:09:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C5F78D5DBF; Thu, 27 Apr 2017 07:09:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fYgmJt_yJh1K; Thu, 27 Apr 2017 07:09:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 31DF95FC54; Thu, 27 Apr 2017 07:09:05 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 825D9E00C7; Thu, 27 Apr 2017 07:09:04 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 531C3C4040D; Thu, 27 Apr 2017 07:09:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1958010176571973096==" MIME-Version: 1.0 Subject: Re: Review Request 57474: Added test for authorization of hierarchical roles. From: Adam B To: Benjamin Bannier , Adam B Cc: mesos , Alexander Rojas Date: Thu, 27 Apr 2017 07:09:04 -0000 Message-ID: <20170427070904.63189.42916@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Adam B X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57474/ X-Sender: Adam B X-ReviewBoard-ShipIt: 1 References: <20170418132833.45424.2869@reviews-vm2.apache.org> In-Reply-To: <20170418132833.45424.2869@reviews-vm2.apache.org> Reply-To: Adam B X-ReviewRequest-Repository: mesos --===============1958010176571973096== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/#review173164 ----------------------------------------------------------- Fix it, then Ship it! LGTM. I will fix the tiny typo when I commit. src/tests/authorization_tests.cpp Line 1493 (original), 1493 (patched) s/crete/create/ - Adam B On April 18, 2017, 6:28 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57474/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 6:28 a.m.) > > > Review request for mesos, Adam B and Benjamin Bannier. > > > Bugs: MESOS-7026 > https://issues.apache.org/jira/browse/MESOS-7026 > > > Repository: mesos > > > Description > ------- > > Adds tests for each of the actions which support hierarchical roles. > > > Diffs > ----- > > src/tests/authorization_tests.cpp 3e18c70738b6b7098f37fadebb799a596e76452d > > > Diff: https://reviews.apache.org/r/57474/diff/5/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > > --===============1958010176571973096==--