From reviews-return-59731-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 27 17:35:35 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CD4AA1995A for ; Thu, 27 Apr 2017 17:35:35 +0000 (UTC) Received: (qmail 39408 invoked by uid 500); 27 Apr 2017 17:35:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 39376 invoked by uid 500); 27 Apr 2017 17:35:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 39365 invoked by uid 99); 27 Apr 2017 17:35:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 17:35:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 05FF01A7B1A; Thu, 27 Apr 2017 17:35:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id A1Ta_9sOpeFc; Thu, 27 Apr 2017 17:35:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 527195F36C; Thu, 27 Apr 2017 17:35:28 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B2863E00B4; Thu, 27 Apr 2017 17:35:27 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A4C3DC406E4; Thu, 27 Apr 2017 17:35:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3742038664887040024==" MIME-Version: 1.0 Subject: Re: Review Request 57935: Recalculate shares only when total scalar quantities have changed. From: Anindya Sinha To: Neil Conway Cc: Mesos Reviewbot , Anindya Sinha , mesos Date: Thu, 27 Apr 2017 17:35:27 -0000 Message-ID: <20170427173527.13692.80648@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anindya Sinha X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57935/ X-Sender: Anindya Sinha References: <20170326011615.8807.78659@reviews-vm2.apache.org> In-Reply-To: <20170326011615.8807.78659@reviews-vm2.apache.org> Reply-To: Anindya Sinha X-ReviewRequest-Repository: mesos --===============3742038664887040024== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57935/ ----------------------------------------------------------- (Updated April 27, 2017, 5:35 p.m.) Review request for mesos and Neil Conway. Changes ------- Rebased on top of changes in hierarchical roles implementation. Summary (updated) ----------------- Recalculate shares only when total scalar quantities have changed. Bugs: MESOS-7138 https://issues.apache.org/jira/browse/MESOS-7138 Repository: mesos Description (updated) ------- In `DRFSorter::update`, we should set the `dirty` flag only when the total scalar quantities have changed in any of the cleints in the hierarchy, and not always. Diffs (updated) ----- src/master/allocator/sorter/drf/sorter.hpp fee58d6d1f08163e2a06a4a20c891fe535c3dcff src/master/allocator/sorter/drf/sorter.cpp a8b35c4deac7a4f0725ccae517a8cbca5b8e1ee7 Diff: https://reviews.apache.org/r/57935/diff/2/ Changes: https://reviews.apache.org/r/57935/diff/1-2/ Testing ------- All tests passed. Thanks, Anindya Sinha --===============3742038664887040024==--