From reviews-return-59754-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 27 23:13:15 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A17EC19F67 for ; Thu, 27 Apr 2017 23:13:15 +0000 (UTC) Received: (qmail 30677 invoked by uid 500); 27 Apr 2017 23:13:15 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 30646 invoked by uid 500); 27 Apr 2017 23:13:15 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 30635 invoked by uid 99); 27 Apr 2017 23:13:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 23:13:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E315ED6662; Thu, 27 Apr 2017 23:13:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2Ztpj-4VsM91; Thu, 27 Apr 2017 23:13:13 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 085DD5F485; Thu, 27 Apr 2017 23:13:13 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 601BAE00C7; Thu, 27 Apr 2017 23:13:12 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 19A34C4040D; Thu, 27 Apr 2017 23:13:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6414365627375735585==" MIME-Version: 1.0 Subject: Re: Review Request 58754: Altered the task command used in an agent test. From: Greg Mann To: Joseph Wu , Vinod Kone Cc: Greg Mann , mesos Date: Thu, 27 Apr 2017 23:13:11 -0000 Message-ID: <20170427231311.10790.9808@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58754/ X-Sender: Greg Mann References: <20170426212956.64641.40026@reviews-vm2.apache.org> In-Reply-To: <20170426212956.64641.40026@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============6414365627375735585== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58754/ ----------------------------------------------------------- (Updated April 27, 2017, 11:13 p.m.) Review request for mesos, Joseph Wu and Vinod Kone. Repository: mesos Description (updated) ------- Previously, the test `SlaveTest.RestartSlaveRequireExecutorAuthentication` used the command 'cat' in an attempt to run a long-lived task. However, this command seems to yield a task that will terminate prematurely in some testing environments. This patch updates the task to use `sleep 120` instead. Diffs ----- src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f Diff: https://reviews.apache.org/r/58754/diff/1/ Testing (updated) ------- Run in CI to verify that the test is no longer flaky. Thanks, Greg Mann --===============6414365627375735585==--